Re: [PATCH net-next v5 00/11] ethtool: Add support for frame preemption

Jakub Kicinski
2022-05-20T22:34:19Z

On Thu, 19 May 2022 18:15:27 -0700 Vinicius Costa Gomes wrote:
> Changes from v4:
> - Went back to exposing the per-queue frame preemption bits via
> ethtool-netlink only, via taprio/mqprio was seen as too much
> trouble. (Vladimir Oltean)
> - Fixed documentation and code/patch organization changes (Vladimir
> Oltean).

First of all - could you please, please, please rev these patches more
than once a year? It's really hard to keep track of the context when
previous version was sent in Jun 2021 :/

I disagree that queue mask belongs in ethtool. It's an attribute of
a queue and should be attached to a queue. The DCBNL parallel is flawed
IMO because pause generation is Rx, not Tx. There is no Rx queue in
Linux, much less per-prio.