From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "Paolo Abeni" <pabeni@redhat.com>,
"Yuwei Wang" <wangyuweihx@gmail.com>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
roopa@nvidia.com, dsahern@kernel.org, 秦迪 <qindi@staff.weibo.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net, neigh: introduce interval_probe_time for periodic probe
Date: Tue, 24 May 2022 11:07:49 -0700 [thread overview]
Message-ID: <20220524110749.6c29464b@kernel.org> (raw)
In-Reply-To: <797c3c53-ce1b-9f60-e253-cda615788f4a@iogearbox.net>
On Tue, 24 May 2022 17:32:57 +0200 Daniel Borkmann wrote:
> Right, maybe we could just split this into two: 1) prevent misconfig (see
> below), and 2) make the timeout configurable as what Yuwei has. Wdyt?
>
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 47b6c1f0fdbb..54625287ee5b 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -1579,7 +1579,7 @@ static void neigh_managed_work(struct work_struct *work)
> list_for_each_entry(neigh, &tbl->managed_list, managed_list)
> neigh_event_send_probe(neigh, NULL, false);
> queue_delayed_work(system_power_efficient_wq, &tbl->managed_work,
> - NEIGH_VAR(&tbl->parms, DELAY_PROBE_TIME));
> + max(NEIGH_VAR(&tbl->parms, DELAY_PROBE_TIME), HZ));
> write_unlock_bh(&tbl->lock);
> }
FWIW that was my reaction as well. Let's do that unless someone
disagrees.
next prev parent reply other threads:[~2022-05-24 18:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 3:17 [PATCH net-next v2] net, neigh: introduce interval_probe_time for periodic probe Yuwei Wang
2022-05-24 8:38 ` Paolo Abeni
2022-05-24 9:38 ` Yuwei Wang
2022-05-24 10:41 ` Paolo Abeni
2022-05-24 14:33 ` Yuwei Wang
2022-05-24 15:32 ` Daniel Borkmann
2022-05-24 18:07 ` Jakub Kicinski [this message]
2022-05-24 19:13 ` Yuwei Wang
2022-05-24 20:53 ` Daniel Borkmann
2022-06-08 15:02 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524110749.6c29464b@kernel.org \
--to=kuba@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qindi@staff.weibo.com \
--cc=roopa@nvidia.com \
--cc=wangyuweihx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).