From: Jakub Kicinski <kuba@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net 0/3] dpaa2-eth: software TSO fixes
Date: Tue, 24 May 2022 11:39:00 -0700 [thread overview]
Message-ID: <20220524113900.0412e086@kernel.org> (raw)
In-Reply-To: <20220522125251.444477-1-ioana.ciornei@nxp.com>
On Sun, 22 May 2022 15:52:48 +0300 Ioana Ciornei wrote:
> This patch fixes the software TSO feature in dpaa2-eth.
>
> There are multiple errors that I made in the initial submission of the
> code, which I didn't caught since I was always running with passthough
> IOMMU.
>
> The bug report came in bugzilla:
> https://bugzilla.kernel.org/show_bug.cgi?id=215886
>
> The bugs are in the Tx confirmation path, where I was trying to retrieve
> a virtual address after DMA unmapping the area. Besides that, another
> dma_unmap call was made with the wrong size.
Thanks for the fixes! FTR it's been applied as commit 7e4d1c237592
("Merge branch 'dpaa2-swtso-fixes'") to net on Sunday.
next prev parent reply other threads:[~2022-05-24 18:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 12:52 [PATCH net 0/3] dpaa2-eth: software TSO fixes Ioana Ciornei
2022-05-22 12:52 ` [PATCH net 1/3] dpaa2-eth: retrieve the virtual address before dma_unmap Ioana Ciornei
2022-05-22 12:52 ` [PATCH net 2/3] dpaa2-eth: use the correct software annotation field Ioana Ciornei
2022-05-22 12:52 ` [PATCH net 3/3] dpaa2-eth: unmap the SGT buffer before accessing its contents Ioana Ciornei
2022-05-24 18:39 ` Jakub Kicinski [this message]
2022-06-01 10:22 ` [PATCH net 0/3] dpaa2-eth: software TSO fixes David Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524113900.0412e086@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).