From: Jason Gunthorpe <jgg@nvidia.com>
To: longli@microsoft.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Ajay Sharma <sharmaajay@microsoft.com>,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [Patch v2 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter
Date: Tue, 24 May 2022 11:10:44 -0300 [thread overview]
Message-ID: <20220524141044.GA2666396@nvidia.com> (raw)
In-Reply-To: <1653382572-14788-13-git-send-email-longli@linuxonhyperv.com>
On Tue, May 24, 2022 at 01:56:12AM -0700, longli@linuxonhyperv.com wrote:
> +struct mana_ib_qp {
> + struct ib_qp ibqp;
> +
> + // Send queue info
> + struct ib_umem *sq_umem;
> + int sqe;
> + u64 sq_gdma_region;
> + u64 sq_id;
There are still lots of coding style violations. Can you get someone
from Microsoft to help you make patches in the expected form?
Also, please don't repost until the next rc1.
Thanks,
Jason
next prev parent reply other threads:[~2022-05-24 14:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 8:56 [Patch v2 00/12] Introduce Microsoft Azure Network Adapter (MANA) RDMA driver longli
2022-05-24 8:56 ` [Patch v2 01/12] net: mana: Add support for auxiliary device longli
2022-05-24 8:56 ` [Patch v2 02/12] net: mana: Record the physical address for doorbell page region longli
2022-05-24 8:56 ` [Patch v2 03/12] net: mana: Handle vport sharing between devices longli
2022-05-24 8:56 ` [Patch v2 04/12] net: mana: Add functions for allocating doorbell page from GDMA longli
2022-05-24 8:56 ` [Patch v2 05/12] net: mana: Set the DMA device max segment size longli
2022-05-24 8:56 ` [Patch v2 06/12] net: mana: Define data structures for protection domain and memory registration longli
2022-05-24 8:56 ` [Patch v2 07/12] net: mana: Export Work Queue functions for use by RDMA driver longli
2022-05-24 8:56 ` [Patch v2 08/12] net: mana: Record port number in netdev longli
2022-05-24 8:56 ` [Patch v2 09/12] net: mana: Move header files to a common location longli
2022-05-24 8:56 ` [Patch v2 10/12] net: mana: Define max values for SGL entries longli
2022-05-24 8:56 ` [Patch v2 11/12] net: mana: Define and process GDMA response code GDMA_STATUS_MORE_ENTRIES longli
2022-05-24 8:56 ` [Patch v2 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter longli
2022-05-24 14:10 ` Jason Gunthorpe [this message]
2022-05-24 18:41 ` Long Li
2022-05-24 18:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524141044.GA2666396@nvidia.com \
--to=jgg@nvidia.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).