From: "Eugenio Pérez" <eperezma@redhat.com>
To: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Parav Pandit <parav@nvidia.com>,
Zhang Min <zhang.min9@zte.com.cn>,
hanand@xilinx.com, Zhu Lingshan <lingshan.zhu@intel.com>,
tanuj.kamde@amd.com, gautam.dawar@amd.com,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Xie Yongji <xieyongji@bytedance.com>,
dinang@xilinx.com, habetsm.xilinx@gmail.com,
Eli Cohen <elic@nvidia.com>,
pabloc@xilinx.com, lvivier@redhat.com,
Dan Carpenter <dan.carpenter@oracle.com>,
lulu@redhat.com, Wu Zongyong <wuzongyong@linux.alibaba.com>,
eperezma@redhat.com, ecree.xilinx@gmail.com,
Piotr.Uminski@intel.com, martinpo@xilinx.com,
Stefano Garzarella <sgarzare@redhat.com>,
Si-Wei Liu <si-wei.liu@oracle.com>,
Longpeng <longpeng2@huawei.com>,
martinh@xilinx.com
Subject: [PATCH v2 2/4] vhost-vdpa: introduce STOP backend feature bit
Date: Tue, 24 May 2022 19:06:08 +0200 [thread overview]
Message-ID: <20220524170610.2255608-3-eperezma@redhat.com> (raw)
In-Reply-To: <20220524170610.2255608-1-eperezma@redhat.com>
Userland knows if it can stop the device or not by checking this feature
bit.
It's only offered if the vdpa driver backend implements the stop()
operation callback, and try to set it if the backend does not offer that
callback is an error.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
drivers/vhost/vdpa.c | 16 +++++++++++++++-
include/uapi/linux/vhost_types.h | 2 ++
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 1f1d1c425573..32713db5831d 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -347,6 +347,14 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v,
return 0;
}
+static bool vhost_vdpa_can_stop(const struct vhost_vdpa *v)
+{
+ struct vdpa_device *vdpa = v->vdpa;
+ const struct vdpa_config_ops *ops = vdpa->config;
+
+ return ops->stop;
+}
+
static long vhost_vdpa_get_features(struct vhost_vdpa *v, u64 __user *featurep)
{
struct vdpa_device *vdpa = v->vdpa;
@@ -575,7 +583,11 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep,
if (cmd == VHOST_SET_BACKEND_FEATURES) {
if (copy_from_user(&features, featurep, sizeof(features)))
return -EFAULT;
- if (features & ~VHOST_VDPA_BACKEND_FEATURES)
+ if (features & ~(VHOST_VDPA_BACKEND_FEATURES |
+ BIT_ULL(VHOST_BACKEND_F_STOP)))
+ return -EOPNOTSUPP;
+ if ((features & BIT_ULL(VHOST_BACKEND_F_STOP)) &&
+ !vhost_vdpa_can_stop(v))
return -EOPNOTSUPP;
vhost_set_backend_features(&v->vdev, features);
return 0;
@@ -624,6 +636,8 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep,
break;
case VHOST_GET_BACKEND_FEATURES:
features = VHOST_VDPA_BACKEND_FEATURES;
+ if (vhost_vdpa_can_stop(v))
+ features |= BIT_ULL(VHOST_BACKEND_F_STOP);
if (copy_to_user(featurep, &features, sizeof(features)))
r = -EFAULT;
break;
diff --git a/include/uapi/linux/vhost_types.h b/include/uapi/linux/vhost_types.h
index 634cee485abb..2758e665791b 100644
--- a/include/uapi/linux/vhost_types.h
+++ b/include/uapi/linux/vhost_types.h
@@ -161,5 +161,7 @@ struct vhost_vdpa_iova_range {
* message
*/
#define VHOST_BACKEND_F_IOTLB_ASID 0x3
+/* Stop device from processing virtqueue buffers */
+#define VHOST_BACKEND_F_STOP 0x4
#endif
--
2.27.0
next prev parent reply other threads:[~2022-05-24 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 17:06 [PATCH v2 0/4] Implement vdpasim stop operation Eugenio Pérez
2022-05-24 17:06 ` [PATCH v2 1/4] vdpa: Add " Eugenio Pérez
2022-05-24 17:06 ` Eugenio Pérez [this message]
2022-05-24 17:06 ` [PATCH v2 3/4] vhost-vdpa: uAPI to stop the device Eugenio Pérez
2022-05-25 2:51 ` Jason Wang
2022-05-25 6:43 ` Eugenio Perez Martin
2022-05-24 17:06 ` [PATCH v2 4/4] vdpa_sim: Implement stop vdpa op Eugenio Pérez
2022-05-25 2:54 ` Jason Wang
2022-05-25 8:40 ` Eugenio Perez Martin
2022-05-25 7:41 ` Stefano Garzarella
2022-05-25 2:49 ` [PATCH v2 0/4] Implement vdpasim stop operation Jason Wang
2022-05-25 6:42 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524170610.2255608-3-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=Piotr.Uminski@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=dinang@xilinx.com \
--cc=ecree.xilinx@gmail.com \
--cc=elic@nvidia.com \
--cc=gautam.dawar@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=martinh@xilinx.com \
--cc=martinpo@xilinx.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabloc@xilinx.com \
--cc=parav@nvidia.com \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=tanuj.kamde@amd.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzongyong@linux.alibaba.com \
--cc=xieyongji@bytedance.com \
--cc=zhang.min9@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).