From: Jakub Kicinski <kuba@kernel.org>
To: Tan Tee Min <tee.min.tan@linux.intel.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Voon Wei Feng <weifeng.voon@intel.com>,
Sit Michael Wei Hong <michael.wei.hong.sit@intel.com>,
Ling Pei Lee <pei.lee.ling@intel.com>,
Looi Hong Aun <hong.aun.looi@intel.com>,
Tan Tee Min <tee.min.tan@intel.com>
Subject: Re: [PATCH net-next 1/1] net: phy: dp83867: retrigger SGMII AN when link change
Date: Wed, 25 May 2022 21:56:29 -0700 [thread overview]
Message-ID: <20220525215629.69af5bf5@kernel.org> (raw)
In-Reply-To: <20220526013714.4119839-1-tee.min.tan@linux.intel.com>
On Thu, 26 May 2022 09:37:14 +0800 Tan Tee Min wrote:
> There is a limitation in TI DP83867 PHY device where SGMII AN is only
> triggered once after the device is booted up. Even after the PHY TPI is
> down and up again, SGMII AN is not triggered and hence no new in-band
> message from PHY to MAC side SGMII.
>
> This could cause an issue during power up, when PHY is up prior to MAC.
> At this condition, once MAC side SGMII is up, MAC side SGMII wouldn`t
> receive new in-band message from TI PHY with correct link status, speed
> and duplex info.
>
> As suggested by TI, implemented a SW solution here to retrigger SGMII
> Auto-Neg whenever there is a link change.
Thanks, sounds like this bug has always been in the driver so we should
add:
Fixes: 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy")
Is that right? Getting a workaround like this into stable eventually
seems like a good idea so Fixes tag will help.
next prev parent reply other threads:[~2022-05-26 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 1:37 [PATCH net-next 1/1] net: phy: dp83867: retrigger SGMII AN when link change Tan Tee Min
2022-05-26 4:56 ` Jakub Kicinski [this message]
2022-05-26 8:18 ` Tan Tee Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525215629.69af5bf5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hong.aun.looi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael.wei.hong.sit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pei.lee.ling@intel.com \
--cc=tee.min.tan@intel.com \
--cc=tee.min.tan@linux.intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).