netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
	netdev@vger.kernel.org
Cc: martinh@xilinx.com, Stefano Garzarella <sgarzare@redhat.com>,
	martinpo@xilinx.com, lvivier@redhat.com, pabloc@xilinx.com,
	Parav Pandit <parav@nvidia.com>, Eli Cohen <elic@nvidia.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Xie Yongji <xieyongji@bytedance.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Zhang Min <zhang.min9@zte.com.cn>,
	Wu Zongyong <wuzongyong@linux.alibaba.com>,
	lulu@redhat.com, Zhu Lingshan <lingshan.zhu@intel.com>,
	Piotr.Uminski@intel.com, Si-Wei Liu <si-wei.liu@oracle.com>,
	ecree.xilinx@gmail.com, gautam.dawar@amd.com,
	habetsm.xilinx@gmail.com, tanuj.kamde@amd.com, hanand@xilinx.com,
	dinang@xilinx.com, Longpeng <longpeng2@huawei.com>
Subject: [PATCH v4 0/4] Implement vdpasim stop operation
Date: Thu, 26 May 2022 14:43:34 +0200	[thread overview]
Message-ID: <20220526124338.36247-1-eperezma@redhat.com> (raw)

Implement stop operation for vdpa_sim devices, so vhost-vdpa will offer
that backend feature and userspace can effectively stop the device.

This is a must before get virtqueue indexes (base) for live migration,
since the device could modify them after userland gets them. There are
individual ways to perform that action for some devices
(VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there was no
way to perform it for any vhost device (and, in particular, vhost-vdpa).

After the return of ioctl with stop != 0, the device MUST finish any
pending operations like in flight requests. It must also preserve all
the necessary state (the virtqueue vring base plus the possible device
specific states) that is required for restoring in the future. The
device must not change its configuration after that point.

After the return of ioctl with stop == 0, the device can continue
processing buffers as long as typical conditions are met (vq is enabled,
DRIVER_OK status bit is enabled, etc).

In the future, we will provide features similar to VHOST_USER_GET_INFLIGHT_FD
so the device can save pending operations.

Comments are welcome.

v4:
* Replace VHOST_STOP to VHOST_VDPA_STOP in vhost ioctl switch case too.

v3:
* s/VHOST_STOP/VHOST_VDPA_STOP/
* Add documentation and requirements of the ioctl above its definition.

v2:
* Replace raw _F_STOP with BIT_ULL(_F_STOP).
* Fix obtaining of stop ioctl arg (it was not obtained but written).
* Add stop to vdpa_sim_blk.

Eugenio Pérez (4):
  vdpa: Add stop operation
  vhost-vdpa: introduce STOP backend feature bit
  vhost-vdpa: uAPI to stop the device
  vdpa_sim: Implement stop vdpa op

 drivers/vdpa/vdpa_sim/vdpa_sim.c     | 21 +++++++++++++++++
 drivers/vdpa/vdpa_sim/vdpa_sim.h     |  1 +
 drivers/vdpa/vdpa_sim/vdpa_sim_blk.c |  3 +++
 drivers/vdpa/vdpa_sim/vdpa_sim_net.c |  3 +++
 drivers/vhost/vdpa.c                 | 34 +++++++++++++++++++++++++++-
 include/linux/vdpa.h                 |  6 +++++
 include/uapi/linux/vhost.h           | 14 ++++++++++++
 include/uapi/linux/vhost_types.h     |  2 ++
 8 files changed, 83 insertions(+), 1 deletion(-)

-- 
2.31.1



             reply	other threads:[~2022-05-26 12:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 12:43 Eugenio Pérez [this message]
2022-05-26 12:43 ` [PATCH v4 1/4] vdpa: Add stop operation Eugenio Pérez
2022-05-26 14:23   ` Stefano Garzarella
2022-05-26 15:32     ` Eugenio Perez Martin
2022-06-01  5:35   ` Eli Cohen
2022-06-01  6:53     ` Eugenio Perez Martin
2022-05-26 12:43 ` [PATCH v4 2/4] vhost-vdpa: introduce STOP backend feature bit Eugenio Pérez
2022-05-26 12:43 ` [PATCH v4 3/4] vhost-vdpa: uAPI to stop the device Eugenio Pérez
2022-06-01 11:03   ` Michael S. Tsirkin
2022-06-01 11:15     ` Eugenio Perez Martin
2022-06-01 19:13       ` Parav Pandit
2022-06-02  6:21         ` Eugenio Perez Martin
2022-05-26 12:43 ` [PATCH v4 4/4] vdpa_sim: Implement stop vdpa op Eugenio Pérez
2022-05-26 14:25   ` Stefano Garzarella
2022-05-26 12:54 ` [PATCH v4 0/4] Implement vdpasim stop operation Parav Pandit
2022-05-27  2:26   ` Jason Wang
2022-05-27  7:55     ` Eugenio Perez Martin
2022-05-31 20:26       ` Parav Pandit
2022-06-01 10:48         ` Eugenio Perez Martin
2022-05-27 10:55   ` Michael S. Tsirkin
2022-05-30  3:39     ` Jason Wang
2022-05-31  5:40       ` Michael S. Tsirkin
2022-05-31  6:44         ` Jason Wang
2022-05-31 20:19       ` Parav Pandit
2022-06-01  2:42         ` Jason Wang
2022-06-01 18:58           ` Parav Pandit
2022-06-02  2:00             ` Jason Wang
2022-06-02  2:59               ` Parav Pandit
2022-06-02  3:53                 ` Jason Wang
2022-06-15  0:10                   ` Parav Pandit
2022-06-15  1:28                     ` Jason Wang
2022-06-16 19:36                       ` Parav Pandit
2022-06-17  1:15                         ` Jason Wang
2022-06-17  2:42                           ` Parav Pandit
2022-06-02  8:57                 ` Eugenio Perez Martin
2022-06-01  9:49         ` Eugenio Perez Martin
2022-06-01 19:30           ` Parav Pandit
2022-06-02  2:02             ` Jason Wang
2022-05-31  5:42 ` Michael S. Tsirkin
2022-05-31  7:13   ` Eugenio Perez Martin
2022-05-31  9:23     ` Michael S. Tsirkin
2022-06-02  2:08 ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220526124338.36247-1-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=Piotr.Uminski@intel.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=dinang@xilinx.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=elic@nvidia.com \
    --cc=gautam.dawar@amd.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=hanand@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lingshan.zhu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longpeng2@huawei.com \
    --cc=lulu@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=martinh@xilinx.com \
    --cc=martinpo@xilinx.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabloc@xilinx.com \
    --cc=parav@nvidia.com \
    --cc=sgarzare@redhat.com \
    --cc=si-wei.liu@oracle.com \
    --cc=tanuj.kamde@amd.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wuzongyong@linux.alibaba.com \
    --cc=xieyongji@bytedance.com \
    --cc=zhang.min9@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).