From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BB95EC43217
	for <netdev@archiver.kernel.org>; Sat, 28 May 2022 03:19:04 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1348250AbiE1DTC (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 27 May 2022 23:19:02 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55000 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231903AbiE1DTB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 27 May 2022 23:19:01 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9F6517FD;
        Fri, 27 May 2022 20:19:00 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 137D660FBD;
        Sat, 28 May 2022 03:19:00 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC1EBC34114;
        Sat, 28 May 2022 03:18:57 +0000 (UTC)
Date:   Fri, 27 May 2022 23:18:56 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>, x86@kernel.org
Subject: Re: [PATCH v5] ftrace: Add FTRACE_MCOUNT_MAX_OFFSET to avoid adding
 weak function
Message-ID: <20220527231856.14000ed1@gandalf.local.home>
In-Reply-To: <20220527163205.421c7828@gandalf.local.home>
References: <20220527163205.421c7828@gandalf.local.home>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, 27 May 2022 16:32:05 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> @@ -4003,7 +4128,11 @@ ftrace_match_record(struct dyn_ftrace *rec, struct ftrace_glob *func_g,
>  	char str[KSYM_SYMBOL_LEN];
>  	char *modname;
>  
> -	kallsyms_lookup(rec->ip, NULL, NULL, &modname, str);
> +	if (lookup_ip(rec->ip, &modname, str)) {
> +		/* This should only happen when a rec is disabled */
> +		WARN_ON_ONCE(!(rec->flags & FTRACE_FL_DISABLED));

It appears that some of the start up tests can call this before the
workqueue sets it to DISABLED, so we need to not WARN_ON() here. :-/

-- Steve


> +		return 0;
> +	}
>