From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC961C433EF for ; Sun, 29 May 2022 00:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbiE2Aex (ORCPT ); Sat, 28 May 2022 20:34:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiE2Aew (ORCPT ); Sat, 28 May 2022 20:34:52 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96E3B9D4E4 for ; Sat, 28 May 2022 17:34:50 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id bo5so7534891pfb.4 for ; Sat, 28 May 2022 17:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fL0vTkTmOld4IH8ZQCpmkRcHGTx86AIT4iKQ1TBlwlc=; b=Zp30KBilhftoj+J2yuSfliXKQtjJ+72Xzal4mPPy3zp1E6NG6kOI2WG3HgBtJtEf1y EIvT2rmoOtOLqUEQXDh1LJfSAP0lwrc4KNtVvr3WYJErx1fIxCziMDoG6APcVOe7lGxm /3pcQXyyhP9Z6hTWj6k0nHtwYtpeyw568jPxSWmoe7hFnB5W1f/y1hYPUcnagOHN7NZ9 rZGnYsrBS5rQY7/8M2XFPIUOpdF+WI2voXeknSgucZ1ZJJTDipGsnXvo8Duhy/VibB9c Q3W/aTJB+Ifev7+2Xm4s5n9SY8gNKVAHYjBanure2XfCjxU0ZnMjnFDqB79427aIxIyy 4yOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fL0vTkTmOld4IH8ZQCpmkRcHGTx86AIT4iKQ1TBlwlc=; b=AYigmQLEHMYXWDSYeCSbl2PC05pBPV+xX1dt5i6iAtLOPLWOiJy0GkKwXiNJhnWgWL xYL31+hR+hB+mDMa8AmvuaHLHR0vitiCc9WtIiDVw3r8oxCteE1yxUyZGCdWHYs2u8RM sfzClHrZ/T8yHYdYk/1FVNOZndZuaZ/wQ3wPpzB/jgeWERUFjQi6EwjTI6bIbDVFATuk kRVsJv5ppfBlWxXV1ZBvmjMgMztNoo9JEZYCyg3xruRkW8hy9DLNy8a/EHe+Nduo7KOi uFKYagAWlD7zAfDM/OtpRUyMYjsAx8qmL+1LPtn2AryHesZWIXYFjVLaArqW3GEryPgy K28A== X-Gm-Message-State: AOAM532gHumuGeENVJ8EtpHa0SmMA7E02MCIoHaS12tg1P3GGfoaqNU4 N2FkEqPmhBaiThEyYAYY88I= X-Google-Smtp-Source: ABdhPJwGIT6P1XM+/dALylPtc4Dtk0b92zvaCBDwLIfULl6N1hOpGvm/2OrhRlO5Js9Uar0yQPvQnA== X-Received: by 2002:a63:8ac3:0:b0:3fa:e447:ec3 with SMTP id y186-20020a638ac3000000b003fae4470ec3mr16496966pgd.606.1653784490118; Sat, 28 May 2022 17:34:50 -0700 (PDT) Received: from hoboy.vegasvil.org ([2601:640:8200:33:e2d5:5eff:fea5:802f]) by smtp.gmail.com with ESMTPSA id b15-20020a17090a10cf00b001dd11e4b927sm2769847pje.39.2022.05.28.17.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 17:34:49 -0700 (PDT) Date: Sat, 28 May 2022 17:34:47 -0700 From: Richard Cochran To: Jonathan Lemon Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, bcm-kernel-feedback-list@broadcom.com, kernel-team@fb.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com Subject: Re: [PATCH net-next v5 2/2] net: phy: broadcom: Add PTP support for some Broadcom PHYs. Message-ID: <20220529003447.GA32026@hoboy.vegasvil.org> References: <20220518223935.2312426-1-jonathan.lemon@gmail.com> <20220518223935.2312426-3-jonathan.lemon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518223935.2312426-3-jonathan.lemon@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, May 18, 2022 at 03:39:35PM -0700, Jonathan Lemon wrote: > +static int bcm_ptp_adjtime_locked(struct bcm_ptp_private *priv, > + s64 delta_ns) > +{ > + struct timespec64 ts; > + int err; > + > + err = bcm_ptp_gettime_locked(priv, &ts, NULL); > + if (!err) { > + set_normalized_timespec64(&ts, ts.tv_sec, > + ts.tv_nsec + delta_ns); This also takes a LONG time when delta is large... > + err = bcm_ptp_settime_locked(priv, &ts); > + } > + return err; > +} Try this instead: s64 ns; err = bcm_ptp_gettime_locked(priv, &ts, NULL); if (err) { return err; } ns = timespec64_to_ns(&ts); ns += delta_ns; ts = ns_to_timespec64(ns); err = bcm_ptp_settime_locked(priv, &ts); return err; Thanks, Richard