From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3166FC433F5 for ; Mon, 30 May 2022 14:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240497AbiE3O3U (ORCPT ); Mon, 30 May 2022 10:29:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241456AbiE3O0M (ORCPT ); Mon, 30 May 2022 10:26:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEA1363FF; Mon, 30 May 2022 06:51:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BA3B60FD4; Mon, 30 May 2022 13:51:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDE62C3411F; Mon, 30 May 2022 13:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653918669; bh=oPb496vJ6O8l9Viexv5dOp3zu04IOVFFRg10fGCG5Ig=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C54/yxhC9cTgwWM8AzQIssmeNp0XUtqleHWlzKl5FHo465Ou4LKDrGJnSXMtO2Rnp qNqJnWw21BhrwRSjyJrfPUBpKXHuz24tgppdS5YOxY4kkR4VBjcQccEk7x/Wl+mI8G CPsD9UBDs2VGRV67AVerfxaQEw3w5ofbWnYyngT3uIiVToAhLAeQIZb9NyPmbTzZwV szr/wae4pcTq5EbR6UUsUIYtbMOa0919jzZub6IaI3c96ke0T+RxLBOHFsC8/OVYd1 gzvwMTx8jaNPXUYMpEm/QY12pIiRUK7oe9/FwjB5XtLnk5Avljm2kmD+qbCU6Z9lAo /VAfp+qFZVSQw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Haowen Bai , Kalle Valo , Sasha Levin , stas.yakovlev@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 05/29] ipw2x00: Fix potential NULL dereference in libipw_xmit() Date: Mon, 30 May 2022 09:50:32 -0400 Message-Id: <20220530135057.1937286-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530135057.1937286-1-sashal@kernel.org> References: <20220530135057.1937286-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Haowen Bai [ Upstream commit e8366bbabe1d207cf7c5b11ae50e223ae6fc278b ] crypt and crypt->ops could be null, so we need to checking null before dereference Signed-off-by: Haowen Bai Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/1648797055-25730-1-git-send-email-baihaowen@meizu.com Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/ipw2x00/libipw_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/ipw2x00/libipw_tx.c b/drivers/net/wireless/intel/ipw2x00/libipw_tx.c index 84205aa508df..daa4f9eb08ff 100644 --- a/drivers/net/wireless/intel/ipw2x00/libipw_tx.c +++ b/drivers/net/wireless/intel/ipw2x00/libipw_tx.c @@ -397,7 +397,7 @@ netdev_tx_t libipw_xmit(struct sk_buff *skb, struct net_device *dev) /* Each fragment may need to have room for encryption * pre/postfix */ - if (host_encrypt) + if (host_encrypt && crypt && crypt->ops) bytes_per_frag -= crypt->ops->extra_mpdu_prefix_len + crypt->ops->extra_mpdu_postfix_len; -- 2.35.1