From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Yu Xiao <yu.xiao@corigine.com>,
Yinjun Zhang <yinjun.zhang@corigine.com>,
Louis Peens <louis.peens@corigine.com>
Subject: Re: [PATCH net] nfp: correct the output of `ethtool --show-fec <intf>`
Date: Mon, 30 May 2022 21:32:32 -0700 [thread overview]
Message-ID: <20220530213232.332b5dff@kernel.org> (raw)
In-Reply-To: <20220530084842.21258-1-simon.horman@corigine.com>
On Mon, 30 May 2022 10:48:42 +0200 Simon Horman wrote:
> The output of `Configured FEC encodings` should display user
> configured/requested value,
That stands to reason, but when I checked what all drivers do 7 out
of 10 upstream drivers at the time used it to report supported modes.
At which point it may be better to change the text in ethtool user
space that try to change the meaning of the field..
> rather than the NIC supported modes list.
>
> Before this patch, the output is:
> # ethtool --show-fec <intf>
> FEC parameters for <intf>:
> Configured FEC encodings: Auto Off RS BaseR
> Active FEC encoding: None
>
> With this patch, the corrected output is:
> # ethtool --show-fec <intf>
> FEC parameters for <intf>:
> Configured FEC encodings: Auto
> Active FEC encoding: None
next prev parent reply other threads:[~2022-05-31 4:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 8:48 [PATCH net] nfp: correct the output of `ethtool --show-fec <intf>` Simon Horman
2022-05-31 4:32 ` Jakub Kicinski [this message]
2022-06-01 1:48 ` Yinjun Zhang
2022-06-01 2:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530213232.332b5dff@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
--cc=yu.xiao@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).