From: Jakub Kicinski <kuba@kernel.org>
To: Yinjun Zhang <yinjun.zhang@corigine.com>
Cc: Simon Horman <simon.horman@corigine.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Yu Xiao <yu.xiao@corigine.com>,
Louis Peens <louis.peens@corigine.com>
Subject: Re: [PATCH net] nfp: correct the output of `ethtool --show-fec <intf>`
Date: Tue, 31 May 2022 19:46:07 -0700 [thread overview]
Message-ID: <20220531194607.7520df10@kernel.org> (raw)
In-Reply-To: <20220601014825.GA10961@nj-rack01-04.nji.corigine.com>
On Wed, 1 Jun 2022 09:48:25 +0800 Yinjun Zhang wrote:
> On Mon, May 30, 2022 at 09:32:32PM -0700, Jakub Kicinski wrote:
> > On Mon, 30 May 2022 10:48:42 +0200 Simon Horman wrote:
> > > The output of `Configured FEC encodings` should display user
> > > configured/requested value,
> >
> > That stands to reason, but when I checked what all drivers do 7 out
> > of 10 upstream drivers at the time used it to report supported modes.
>
> It seems you're right. I agree it's OK that nfp driver keep the same with
> majority drivers' implementations.
FWIW this is what I found in my notes:
get:
s - supported
c - configured
set:
1 - single mode
m - multiple modes
nfp | ionic | lio | cxgb4 | hns3 | i40e | ice | mlx5 | qede | sfc | bnxt
-----------------------------------------------------------------------------
get | s | s | s | s | s | c? | s | c? | s | c? |
set | 1 | 1 | 1 | m | m | 1 | 1 | m? | m | m |
I don't know how accurate that was, hard to tell those things
by looking only at the kernel driver.
> > At which point it may be better to change the text in ethtool user
> > space that try to change the meaning of the field..
>
> To adapt to both implementations, "Supported/Configured FEC encodings"
> would be a compromise I think.
Yup, it should help avoid bug reports. I don't have better ideas :(
prev parent reply other threads:[~2022-06-01 2:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 8:48 [PATCH net] nfp: correct the output of `ethtool --show-fec <intf>` Simon Horman
2022-05-31 4:32 ` Jakub Kicinski
2022-06-01 1:48 ` Yinjun Zhang
2022-06-01 2:46 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531194607.7520df10@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
--cc=yu.xiao@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).