From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68596C433F5 for ; Wed, 1 Jun 2022 02:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236148AbiFACqL (ORCPT ); Tue, 31 May 2022 22:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232241AbiFACqK (ORCPT ); Tue, 31 May 2022 22:46:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A83F35A5B2 for ; Tue, 31 May 2022 19:46:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 42DC360EE7 for ; Wed, 1 Jun 2022 02:46:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63D79C385A9; Wed, 1 Jun 2022 02:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654051568; bh=g2SNfgGfMdMKhYPLabKUvmye2yuPbn4g3VlhMuHDe3A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nzgOu0VLgbkWecqMl6iA8QbplMcIgwvtpNkraQ20SvBBawd6aJRTZq5/iYF9+5L6v Qm4TgE7zcDLr2tMffYT+R7lRLoNa8JqJjFUO3zAmpu3P8x0sLqb5Disz3ikaVZxEWb /Pgrcdzwrf5pEnrSemnO6sKKIqjMQNUgiMto8kGWKjhkDIYi2GfWKUCSk9iOWUWGGx eykbtWj7nLXWB6TN1Z/oa6AAQ7YoPXImZ9Y4DlhUui0F/gReEA1i8WRJiQTCqVm0Gy x0H1E5YEvOC5wIR3Ob02oJMt3uI/XLqY1l6PbN8IcQBsOsm8SSYVg6gAJYYOioDvk/ LwdNYoCEB454Q== Date: Tue, 31 May 2022 19:46:07 -0700 From: Jakub Kicinski To: Yinjun Zhang Cc: Simon Horman , David Miller , netdev@vger.kernel.org, oss-drivers@corigine.com, Yu Xiao , Louis Peens Subject: Re: [PATCH net] nfp: correct the output of `ethtool --show-fec ` Message-ID: <20220531194607.7520df10@kernel.org> In-Reply-To: <20220601014825.GA10961@nj-rack01-04.nji.corigine.com> References: <20220530084842.21258-1-simon.horman@corigine.com> <20220530213232.332b5dff@kernel.org> <20220601014825.GA10961@nj-rack01-04.nji.corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 1 Jun 2022 09:48:25 +0800 Yinjun Zhang wrote: > On Mon, May 30, 2022 at 09:32:32PM -0700, Jakub Kicinski wrote: > > On Mon, 30 May 2022 10:48:42 +0200 Simon Horman wrote: > > > The output of `Configured FEC encodings` should display user > > > configured/requested value, > > > > That stands to reason, but when I checked what all drivers do 7 out > > of 10 upstream drivers at the time used it to report supported modes. > > It seems you're right. I agree it's OK that nfp driver keep the same with > majority drivers' implementations. FWIW this is what I found in my notes: get: s - supported c - configured set: 1 - single mode m - multiple modes nfp | ionic | lio | cxgb4 | hns3 | i40e | ice | mlx5 | qede | sfc | bnxt ----------------------------------------------------------------------------- get | s | s | s | s | s | c? | s | c? | s | c? | set | 1 | 1 | 1 | m | m | 1 | 1 | m? | m | m | I don't know how accurate that was, hard to tell those things by looking only at the kernel driver. > > At which point it may be better to change the text in ethtool user > > space that try to change the meaning of the field.. > > To adapt to both implementations, "Supported/Configured FEC encodings" > would be a compromise I think. Yup, it should help avoid bug reports. I don't have better ideas :(