From: Jakub Kicinski <kuba@kernel.org>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: Menglong Dong <imagedong@tencent.com>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/3] net: skb: use auto-generation to convert skb drop reason to string
Date: Tue, 31 May 2022 20:43:25 -0700 [thread overview]
Message-ID: <20220531204325.5ba1362f@kernel.org> (raw)
In-Reply-To: <CADxym3bQ96s_tsQeE_1_TFNafTvzQfRr9WLB40urZCgn4a2C0A@mail.gmail.com>
On Wed, 1 Jun 2022 11:27:41 +0800 Menglong Dong wrote:
> > > +#include <linux/kernel.h>
> >
> > Why?
>
> Oh, you noticed it. To simplify the code in dropreason_str.c, as
> EXPORT_SYMBOL() is used. Okay, I'll move it to the generation
> part.
IMHO you can move the EXPORT_SYMBOL() to skbuff.c, with a comment
saying that the array itself is in an auto-generated source.
Avoid avoid to "echo" both the EXPORT and the include.
next prev parent reply other threads:[~2022-06-01 3:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 8:11 [PATCH net-next v2 0/3] reorganize the code of the enum skb_drop_reason menglong8.dong
2022-05-30 8:11 ` [PATCH net-next v2 1/3] net: skb: move enum skb_drop_reason to standalone header file menglong8.dong
2022-05-30 8:12 ` [PATCH net-next v2 2/3] net: skb: use auto-generation to convert skb drop reason to string menglong8.dong
2022-05-30 10:01 ` kernel test robot
2022-05-30 14:23 ` Philip Li
2022-05-30 15:25 ` kernel test robot
2022-05-30 20:13 ` Jakub Kicinski
2022-06-01 3:27 ` Menglong Dong
2022-06-01 3:43 ` Jakub Kicinski [this message]
2022-05-30 8:12 ` [PATCH net-next v2 3/3] net: dropreason: reformat the comment fo skb drop reasons menglong8.dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531204325.5ba1362f@kernel.org \
--to=kuba@kernel.org \
--cc=imagedong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).