From: Jakub Kicinski <kuba@kernel.org>
To: "Tham, Mun Yew" <mun.yew.tham@intel.com>
Cc: Joyce Ooi <joyce.ooi@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: eth: altera: set rx and tx ring size before init_dma call
Date: Tue, 31 May 2022 20:50:11 -0700 [thread overview]
Message-ID: <20220531205011.4e17bc11@kernel.org> (raw)
In-Reply-To: <20220531025117.13822-1-mun.yew.tham@intel.com>
On Tue, 31 May 2022 10:51:17 +0800 Tham, Mun Yew wrote:
> It is more appropriate to set the rx and tx ring size before calling
> the init function for the dma.
Improve the commit message please, this tells us nothing.
It's hardly a well know software design best practice to set some
random thing before calling another random thing.
AFAICT neither dma implementation upstream cares about
priv->[tr]x_ring_size, do they?
If you're doing this to prepare for adding another DMA engine,
please post this patch together with the support being added.
next prev parent reply other threads:[~2022-06-01 3:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 2:51 [PATCH] net: eth: altera: set rx and tx ring size before init_dma call Tham, Mun Yew
2022-06-01 3:50 ` Jakub Kicinski [this message]
2022-06-02 1:40 ` Tham, Mun Yew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531205011.4e17bc11@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joyce.ooi@intel.com \
--cc=mun.yew.tham@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).