From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F18DC433EF for ; Tue, 31 May 2022 20:55:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245211AbiEaUzJ (ORCPT ); Tue, 31 May 2022 16:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243676AbiEaUzI (ORCPT ); Tue, 31 May 2022 16:55:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 474F69CF71 for ; Tue, 31 May 2022 13:55:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E7432B816BF for ; Tue, 31 May 2022 20:55:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F834C3411D; Tue, 31 May 2022 20:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654030504; bh=GjJNQU//wx0PbaEfMI0ICViHZB7MPwpvObHnp9yMb8A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kLC/81VaPmRr2bxCs295X8V2rhPABX21tr3XQXawBbXI2RrAxumXZ7dFvWFxBj3+N +sfQuACPPpnIGW0hdx3PIkgEVFfG9ygs3QIoMqWCuYcMb36c2rxk3XkmgS8h66vbJe V2QH4RtbVb8IOKQetyzgQP3qgBvRVjc49/ZZ/rMGdh/OLJugt8VQceFc567wOOrvO2 3Co9kbb9GUAUvj19aOGWP5br4VhuU7lDZrugJdaEYlKcemjmBxzlM9qCHgvT13LJSF wuoiGX1ol72SejFUQBjtkcJj+QkSp4suQvYJv8LTcBvhc9eY+ZhM/dtilAlCq4iYm4 z86DETB38A+Tg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, Leon Romanovsky , Dan Carpenter , Saeed Mahameed Subject: [net 1/7] net/mlx5: Don't use already freed action pointer Date: Tue, 31 May 2022 13:54:41 -0700 Message-Id: <20220531205447.99236-2-saeed@kernel.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220531205447.99236-1-saeed@kernel.org> References: <20220531205447.99236-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leon Romanovsky The call to mlx5dr_action_destroy() releases "action" memory. That pointer is set to miss_action later and generates the following smatch error: drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c:53 set_miss_action() warn: 'action' was already freed. Make sure that the pointer is always valid by setting NULL after destroy. Fixes: 6a48faeeca10 ("net/mlx5: Add direct rule fs_cmd implementation") Reported-by: Dan Carpenter Signed-off-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c index 728f81882589..6a9abba92df6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c @@ -44,11 +44,10 @@ static int set_miss_action(struct mlx5_flow_root_namespace *ns, err = mlx5dr_table_set_miss_action(ft->fs_dr_table.dr_table, action); if (err && action) { err = mlx5dr_action_destroy(action); - if (err) { - action = NULL; - mlx5_core_err(ns->dev, "Failed to destroy action (%d)\n", - err); - } + if (err) + mlx5_core_err(ns->dev, + "Failed to destroy action (%d)\n", err); + action = NULL; } ft->fs_dr_table.miss_action = action; if (old_miss_action) { -- 2.36.1