From: Jakub Kicinski <kuba@kernel.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: stmmac: use dev_err_probe() for reporting mdio bus registration failure
Date: Wed, 1 Jun 2022 18:03:14 -0700 [thread overview]
Message-ID: <20220601180314.02e4d84e@kernel.org> (raw)
In-Reply-To: <20220601142226.1123110-1-linux@rasmusvillemoes.dk>
On Wed, 1 Jun 2022 16:22:26 +0200 Rasmus Villemoes wrote:
> if (ret < 0) {
> - dev_err(priv->device,
> + dev_err_probe(priv->device, ret,
> "%s: MDIO bus (id: %d) registration failed",
> __func__, priv->plat->bus_id);
Please adjust the indent of the continuation lines.
And fix the spelling checkpatch also points out.
next prev parent reply other threads:[~2022-06-02 1:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 14:22 [PATCH] net: stmmac: use dev_err_probe() for reporting mdio bus registration failure Rasmus Villemoes
2022-06-02 1:03 ` Jakub Kicinski [this message]
2022-06-02 7:48 ` [PATCH v2] " Rasmus Villemoes
2022-06-02 18:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601180314.02e4d84e@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).