From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B2CC433EF for ; Thu, 2 Jun 2022 01:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232762AbiFBBDV (ORCPT ); Wed, 1 Jun 2022 21:03:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232569AbiFBBDT (ORCPT ); Wed, 1 Jun 2022 21:03:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E26E525C1E2; Wed, 1 Jun 2022 18:03:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9ACC8B81D9C; Thu, 2 Jun 2022 01:03:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01EEAC385B8; Thu, 2 Jun 2022 01:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654131796; bh=wksuz7vaU/eT//E6IgpXwPJq8QtyuB6m7LjRu8m7SC4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qha8JLVY2iWPYuve2RGON4YDTNKfH+xK8C0vhdhsGZaiuONp0bzbvfBe5GCdbr96F FGuk6sWryGYBGZf99Ktq+s6EtTg03fYEvi/u4jxdRf3VTPaCRmmYjmc1BsH8ZUqwyK Ja45OsmwNnZBNd2JfqE6UXscH0TQMV86b4Q7yYSJAfcxx0bfZuQ+K6vgmaa6c48FCR 6X3LTLZUov3OoHFU+IVhOS23wHedUQvSLF0uRaj0CvzY0k4RgZ1yFGG7vryX0h2jtf d3BoKuabKLe67ngushbsRUKP+bQ4p2i5lNabIcWWhkPL1rVKHa6wHKZRkalyh/wDRE VX/sOmR+dtUhg== Date: Wed, 1 Jun 2022 18:03:14 -0700 From: Jakub Kicinski To: Rasmus Villemoes Cc: Giuseppe Cavallaro , Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH] net: stmmac: use dev_err_probe() for reporting mdio bus registration failure Message-ID: <20220601180314.02e4d84e@kernel.org> In-Reply-To: <20220601142226.1123110-1-linux@rasmusvillemoes.dk> References: <20220601142226.1123110-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 1 Jun 2022 16:22:26 +0200 Rasmus Villemoes wrote: > if (ret < 0) { > - dev_err(priv->device, > + dev_err_probe(priv->device, ret, > "%s: MDIO bus (id: %d) registration failed", > __func__, priv->plat->bus_id); Please adjust the indent of the continuation lines. And fix the spelling checkpatch also points out.