From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52676C43334 for ; Thu, 2 Jun 2022 18:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237897AbiFBSOI (ORCPT ); Thu, 2 Jun 2022 14:14:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234302AbiFBSOG (ORCPT ); Thu, 2 Jun 2022 14:14:06 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CDD92BE2 for ; Thu, 2 Jun 2022 11:14:05 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id i1so5151397plg.7 for ; Thu, 02 Jun 2022 11:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2hzKsxy3GSyzH3VoPq74Ra2M46bw5Ap28I/rHJv3+tc=; b=rq2vHBiEC8VMhleqYRJItNirIKM61m3R7HxvIwMhcznlxp4rEHQLbZvFoIRBA+QhAN H0xw5egFOCZE+Dj/U7jrX6ZCAiErSQ9XG8+OuIb714LahEBjSPGFU6QlBBOxLn7sKQ1c d8N4FSsRwf7+Bah9rO0E5GgBJAY/gRFchcen13kA74EDDkHFXv+pXOn6W3LAT9rOJziR +ZXdXVyLaMKYOwyJOdreyvSHckjLLSJaXYEvo511Dvew34ecpL+/cqclBF8f40xwqZtg Y+0arLu4Fsx9+DmK4w/i3K7GSUI/GT9P5pi9LRAdGLpn+dROFGSHvmDvG2HBiZHLKV1z eznA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2hzKsxy3GSyzH3VoPq74Ra2M46bw5Ap28I/rHJv3+tc=; b=2EumhCWx7pPurLU8yoMSyUgw7kL6VQIZgNq1ShVRFi3lmgFXLCP/F9n2F6YyqEnmzF lP262qoM36DUcigbZhjgtE/xx8gtcgzHtGgxdk3COziSTcw0S3iEdLUsHP2UemP4kFN5 KQJOTiUDEdlWodGgPEczK5mzmEnp/Zl9RWTYmNhoEKd7RPwX4XZ9xRwYwyjrIg46tmBv luE+D1r/0omNws0u6gq3mWaFILsC7+w9VfIJH7UCo97Mmzcnu+g2PUdemRu2L5m5oiXs DQgx9nzFpk2aTw3JNxg74sQ9coEWflkjeEPV3O1ClQBRoCMzZ9CDGEIbBEnRoE22/dqE QRmA== X-Gm-Message-State: AOAM530EA7LTg9B+bPNdPPNtCpS8vAUqrRnoe/sEWF/Em+GLAAbU9PmA KlPfB5D75WCD+bMa61rEN/P9Nw== X-Google-Smtp-Source: ABdhPJwxo235xizUNRexwPvS8t+xM23zzOIJMb4n64zyUc5d3kEkj6ZgoqLvyhOL613HmfHYlNNQ5Q== X-Received: by 2002:a17:903:240e:b0:158:eab9:2662 with SMTP id e14-20020a170903240e00b00158eab92662mr6067700plo.87.1654193645056; Thu, 02 Jun 2022 11:14:05 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id k7-20020aa79987000000b005104c6d7941sm3921224pfh.31.2022.06.02.11.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 11:14:04 -0700 (PDT) Date: Thu, 2 Jun 2022 11:14:01 -0700 From: Stephen Hemminger To: Jakub Kicinski Cc: Joakim Tjernlund , "stable@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH] net-sysfs: allow changing sysfs carrier when interface is down Message-ID: <20220602111401.31bcbe35@hermes.local> In-Reply-To: <20220602105215.12aff895@kernel.org> References: <20220602003523.19530-1-joakim.tjernlund@infinera.com> <20220601180147.40a6e8ea@kernel.org> <4b700cbc93bc087115c1e400449bdff48c37298d.camel@infinera.com> <20220602085645.5ecff73f@hermes.local> <20220602095756.764471e8@kernel.org> <20220602105215.12aff895@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2 Jun 2022 10:52:15 -0700 Jakub Kicinski wrote: > On Thu, 2 Jun 2022 17:15:13 +0000 Joakim Tjernlund wrote: > > > What is "our HW", what kernel driver does it use and why can't the > > > kernel driver take care of making sure the device is not accessed > > > when it'd crash the system? > > > > It is a custom asic with some homegrown controller. The full config path is too complex for kernel too > > know and depends on user input. > > We have a long standing tradition of not caring about user space > drivers in netdev land. I see no reason to merge this patch upstream. > > > > > Maybe so but it seems to me that this limitation was put in place without much thought. > > > > > > Don't make unnecessary disparaging statements about someone else's work. > > > Whoever that person was. > > > > That was not meant the way you read it, sorry for being unclear. > > The commit from 2012 simply says: > > net: allow to change carrier via sysfs > > > > Make carrier writable > > Yeah, IIUC the interface was created for software devices. If you want to discussion of original patch see: https://patchwork.ozlabs.org/project/netdev/patch/1314715608-978-2-git-send-email-jpirko@redhat.com/ PS: if you have lots of userspace handling, you should be using netlink not sysfs for management