From: Stephen Hemminger <stephen@networkplumber.org>
To: Andy Roulin <aroulin@nvidia.com>
Cc: fruggeri@arista.com, netdev@vger.kernel.org
Subject: Re: neighbour netlink notifications delivered in wrong order
Date: Mon, 6 Jun 2022 20:19:10 -0700 [thread overview]
Message-ID: <20220606201910.2da95056@hermes.local> (raw)
In-Reply-To: <ed6768c1-80b8-aee2-e545-b51661d49336@nvidia.com>
On Mon, 6 Jun 2022 19:07:04 -0700
Andy Roulin <aroulin@nvidia.com> wrote:
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 54625287ee5b..a91dfcbfc01c 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -2531,23 +2531,19 @@ static int neigh_fill_info(struct sk_buff *skb,
> struct neighbour *neigh,
> if (nla_put(skb, NDA_DST, neigh->tbl->key_len, neigh->primary_key))
> goto nla_put_failure;
>
> - read_lock_bh(&neigh->lock);
> ndm->ndm_state = neigh->nud_state;
Accessing neighbor state outside of lock is not safe.
But you should be able to use RCU here??
next prev parent reply other threads:[~2022-06-07 3:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 23:01 neighbour netlink notifications delivered in wrong order Francesco Ruggeri
2022-06-07 2:07 ` Andy Roulin
2022-06-07 3:19 ` Stephen Hemminger [this message]
2022-06-07 16:29 ` Francesco Ruggeri
2022-06-07 17:32 ` Stephen Hemminger
2022-06-07 20:03 ` Francesco Ruggeri
2022-06-08 3:49 ` Andy Roulin
2022-06-09 16:40 ` Francesco Ruggeri
2022-06-10 16:18 ` Francesco Ruggeri
2022-06-16 18:33 ` Andy Roulin
2023-04-11 19:49 ` Kevin Mitchell
2023-04-12 0:41 ` Stephen Hemminger
2023-04-12 1:22 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606201910.2da95056@hermes.local \
--to=stephen@networkplumber.org \
--cc=aroulin@nvidia.com \
--cc=fruggeri@arista.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).