From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E46C8CCA47C for ; Tue, 7 Jun 2022 19:46:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353343AbiFGTqW (ORCPT ); Tue, 7 Jun 2022 15:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357232AbiFGTo5 (ORCPT ); Tue, 7 Jun 2022 15:44:57 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F85E64D2F; Tue, 7 Jun 2022 11:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654625921; x=1686161921; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zLkJctTdmaiTJ2pGBTIY3B88/G8zacyNgJx04l1EhMA=; b=UMlkvZId5DZE/XR51blN5RKkhSNqGBLQExVWCZqOVDfcatoRZdRJM3ya xQ+F8H1idPxTLmYSzafMQ+nSwE9G2XQQigjhIXzAATiwPUAZINprN5/5r P5lmH/GcjtmAoLCacKlVKY+nwSKrjWHTNeeQLhK1FfB2Fahl5Koham5ux 6IAcy6P9Rxesw/LBxqDPN34e2Jz35mDpI6vwfR2yJjwd7Lkq+h+rN9SJY yv0Pzy8krLG7Lck5kp9v1zU6PPkL5FKI3xrSY2CyZZxm37ArSModfSEad vC0uv0xjt9kiN+DN1wxnbna//LuzDtH37/WelQOF1W8jL4V1XLBjhccGQ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="302096349" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="302096349" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 11:18:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="907165819" Received: from anguy11-desk2.jf.intel.com ([10.166.244.147]) by fmsmga005.fm.intel.com with ESMTP; 07 Jun 2022 11:18:39 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com Cc: Olivier Matz , netdev@vger.kernel.org, anthony.l.nguyen@intel.com, stable@vger.kernel.org, Nicolas Dichtel , Konrad Jankowski Subject: [PATCH net 1/2] ixgbe: fix bcast packets Rx on VF after promisc removal Date: Tue, 7 Jun 2022 11:15:37 -0700 Message-Id: <20220607181538.748786-2-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607181538.748786-1-anthony.l.nguyen@intel.com> References: <20220607181538.748786-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Olivier Matz After a VF requested to remove the promiscuous flag on an interface, the broadcast packets are not received anymore. This breaks some protocols like ARP. In ixgbe_update_vf_xcast_mode(), we should keep the IXGBE_VMOLR_BAM bit (Broadcast Accept) on promiscuous removal. This flag is already set by default in ixgbe_set_vmolr() on VF reset. Fixes: 8443c1a4b192 ("ixgbe, ixgbevf: Add new mbox API xcast mode") Cc: stable@vger.kernel.org Cc: Nicolas Dichtel Signed-off-by: Olivier Matz Tested-by: Konrad Jankowski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c index 7f11c0a8e7a9..8d108a78941b 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c @@ -1184,9 +1184,9 @@ static int ixgbe_update_vf_xcast_mode(struct ixgbe_adapter *adapter, switch (xcast_mode) { case IXGBEVF_XCAST_MODE_NONE: - disable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE | + disable = IXGBE_VMOLR_ROMPE | IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE; - enable = 0; + enable = IXGBE_VMOLR_BAM; break; case IXGBEVF_XCAST_MODE_MULTI: disable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE; -- 2.35.1