From: Jakub Kicinski <kuba@kernel.org>
To: David Ahern <dsahern@kernel.org>
Cc: Jiri Pirko <jiri@resnulli.us>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, steffen.klassert@secunet.com,
jreuter@yaina.de, razor@blackwall.org, kgraul@linux.ibm.com,
ivecera@redhat.com, jmaloy@redhat.com, ying.xue@windriver.com,
lucien.xin@gmail.com, arnd@arndb.de, yajun.deng@linux.dev,
atenart@kernel.org, richardsonnick@google.com,
hkallweit1@gmail.com, linux-hams@vger.kernel.org,
dev@openvswitch.org, linux-s390@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next] net: rename reference+tracking helpers
Date: Wed, 8 Jun 2022 20:29:34 -0700 [thread overview]
Message-ID: <20220608202934.6412b843@kernel.org> (raw)
In-Reply-To: <f263209c-509c-5f6b-865c-cd5d38d29549@kernel.org>
On Wed, 8 Jun 2022 16:58:08 -0600 David Ahern wrote:
> On 6/8/22 8:58 AM, Jakub Kicinski wrote:
> > IMO to encourage use of the track-capable API we could keep their names
> > short and call the legacy functions __netdev_hold() as I mentioned or
> > maybe netdev_hold_notrack().
>
> I like that option. Similar to the old nla_parse functions that were
> renamed with _deprecated - makes it easier to catch new uses.
Well, not really a perfect parallel because _deprecated nla has to stay
forever, given it behaves differently, while _notrack would hopefully
die either thru conversion or someone rightly taking an axe to the
cobwebbed code.
Either way, I hope nobody is against merging the current patch.
next prev parent reply other threads:[~2022-06-09 3:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 4:39 [PATCH net-next] net: rename reference+tracking helpers Jakub Kicinski
2022-06-08 8:27 ` Jiri Pirko
2022-06-08 14:58 ` Jakub Kicinski
2022-06-08 22:58 ` David Ahern
2022-06-08 23:00 ` Eric Dumazet
2022-06-09 11:49 ` Paolo Abeni
2022-06-09 13:53 ` Eric Dumazet
2022-06-09 3:29 ` Jakub Kicinski [this message]
2022-06-09 4:40 ` Jiri Pirko
2022-06-10 5:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608202934.6412b843@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=jmaloy@redhat.com \
--cc=jreuter@yaina.de \
--cc=kgraul@linux.ibm.com \
--cc=linux-hams@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=richardsonnick@google.com \
--cc=steffen.klassert@secunet.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=yajun.deng@linux.dev \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).