From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Michal Kubecek <mkubecek@suse.cz>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: phy: add remote fault support
Date: Wed, 8 Jun 2022 20:40:44 -0700 [thread overview]
Message-ID: <20220608204044.5a09bc59@kernel.org> (raw)
In-Reply-To: <20220608122322.772950-3-o.rempel@pengutronix.de>
On Wed, 8 Jun 2022 14:23:22 +0200 Oleksij Rempel wrote:
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 508f1149665b..94a95e60cb45 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -564,6 +564,7 @@ struct macsec_ops;
> * @advertising: Currently advertised linkmodes
> * @adv_old: Saved advertised while power saving for WoL
> * @lp_advertising: Current link partner advertised linkmodes
> + * @lp_remote_fault: Current link partner advertised remote fault
> * @eee_broken_modes: Energy efficient ethernet modes which should be prohibited
> * @autoneg: Flag autoneg being used
> * @link: Current link state
> @@ -646,6 +647,10 @@ struct phy_device {
> u8 master_slave_set;
> u8 master_slave_state;
>
> + u8 remote_fault_set;
> + u8 remote_fault_get;
> + u8 remote_fault_state;
./scripts/kernel-doc :
include/linux/phy.h:717: warning: Function parameter or member 'remote_fault_set' not described in 'phy_device'
include/linux/phy.h:717: warning: Function parameter or member 'remote_fault_get' not described in 'phy_device'
include/linux/phy.h:717: warning: Function parameter or member 'remote_fault_state' not described in 'phy_device'
include/uapi/linux/ethtool.h:2139: warning: Function parameter or member 'remote_fault_cfg' not described in 'ethtool_link_settings'
include/uapi/linux/ethtool.h:2139: warning: Function parameter or member 'remote_fault_state' not described in 'ethtool_link_settings'
next prev parent reply other threads:[~2022-06-09 3:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 12:23 [PATCH net-next v2 0/2] net: add remote fault support Oleksij Rempel
2022-06-08 12:23 ` [PATCH net-next v2 1/2] net: phy: move common code to separate genphy_c45_aneg_done_lp_clean() function Oleksij Rempel
2022-06-08 12:23 ` [PATCH net-next v2 2/2] net: phy: add remote fault support Oleksij Rempel
2022-06-09 3:40 ` Jakub Kicinski [this message]
2022-06-08 13:08 ` [PATCH net-next v2 0/2] net: " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608204044.5a09bc59@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).