From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Lior Nahmanson <liorna@nvidia.com>,
edumazet@google.com, davem@davemloft.net, netdev@vger.kernel.org,
Raed Salem <raeds@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Ben Ben-Ishay <benishay@nvidia.com>
Subject: Re: [PATCH net-next v3 2/3] net/macsec: Add MACsec skb extension Rx Data path support
Date: Tue, 14 Jun 2022 09:14:38 -0700 [thread overview]
Message-ID: <20220614091438.3d0665d9@kernel.org> (raw)
In-Reply-To: <e95ebed542745609619701b21220647668c89081.camel@redhat.com>
On Tue, 14 Jun 2022 15:55:13 +0200 Paolo Abeni wrote:
> The main reason I suggested to look for the a possible alternative to
> the skb extension is that the GRO stage is becoming bigger (and slower)
> with any of such addition.
>
> The 'slow_gro' protects the common use-case from any additional
> conditionals and intructions, I still have some concerns due to the
> increased code size.
>
> This is not a reject, I'm mostly looking for a 2nd opinion.
Shooting from the hip a little bit, but macsec being a tightly bound L2
upper maybe metadata dst is a workable solution for carrying the sci and
offload status between upper and lower? The range of values should be
well known and limited.
next prev parent reply other threads:[~2022-06-14 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 11:19 [PATCH net-next v3 00/3] Introduce MACsec offload SKB extension Lior Nahmanson
2022-06-13 11:19 ` [PATCH net-next v3 1/3] net/macsec: Add MACsec skb extension Tx Data path support Lior Nahmanson
2022-06-13 11:19 ` [PATCH net-next v3 2/3] net/macsec: Add MACsec skb extension Rx " Lior Nahmanson
2022-06-14 13:55 ` Paolo Abeni
2022-06-14 16:14 ` Jakub Kicinski [this message]
2022-06-21 12:39 ` Lior Nahmanson
2022-06-21 19:26 ` Jakub Kicinski
2022-07-12 6:50 ` Lior Nahmanson
2022-07-13 0:01 ` Jakub Kicinski
2022-07-13 6:21 ` Lior Nahmanson
2022-07-13 18:34 ` Jakub Kicinski
2022-07-13 19:31 ` Saeed Mahameed
2022-06-13 11:19 ` [PATCH net-next v3 3/3] net/macsec: Move some code for sharing with various drivers that implements offload Lior Nahmanson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614091438.3d0665d9@kernel.org \
--to=kuba@kernel.org \
--cc=benishay@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=liorna@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raeds@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).