From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A136C433EF for ; Wed, 15 Jun 2022 17:46:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242330AbiFORq4 (ORCPT ); Wed, 15 Jun 2022 13:46:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230258AbiFORqz (ORCPT ); Wed, 15 Jun 2022 13:46:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D39F153E3A for ; Wed, 15 Jun 2022 10:46:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E4A561B83 for ; Wed, 15 Jun 2022 17:46:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61526C34115; Wed, 15 Jun 2022 17:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655315213; bh=ooKADeM00koUfd1W4RU/WAsSy7gZaiXcy6jOy2REyPI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qR+os5uzs7/Vktrc+xuLhJsX1GGqgWeaj93IrZQr5C4LXr8mn+ZXrxq81/KNl5bZV Ao9Pdnt/Fm3SUSnBTwmgtkdtwT+nYq4pnap6nmvIWOM/xJBlObRPA+SjRjOZS7dnyV L2/Ae8zfEHK/km7rb5DaeUUt+BVf/p+uBMLBRbsxDRvrvhccZFk5nbHjxA+VZPwGFf xQioru/+gMll/BmxM9V8Vy+qkxb5NVscHe7NzPZIVIamaEtrtGJS573tOlRaiojM65 TqEdsmx2vJGCQtmP2AFy/W6SZmyNhzj2fcB1TQ2qThIkETEVUiB5APRf/ynRlXGmsE zXACksx7RPB4w== Date: Wed, 15 Jun 2022 10:46:52 -0700 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Andrew Lunn , Marek =?UTF-8?B?QmVow7pu?= , "David S. Miller" , Eric Dumazet , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org, Paolo Abeni , Robert Hancock , Vivien Didelot , Vladimir Oltean Subject: Re: [PATCH net-next 02/15] net: phylink: add phylink_pcs_inband() Message-ID: <20220615104652.591f5e98@kernel.org> In-Reply-To: References: <20220614224652.09d4c287@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 15 Jun 2022 09:16:54 +0100 Russell King (Oracle) wrote: > > Patch 1 does not need to be backported so I presume it can lose the > > fixes tag? > > As the commit talks about fixing something, in my experience the commit > will get automatically selected for backporting to stable trees whether > or not it has a fixes tag on it. The only way to stop that happening is > not through avoiding a fixes tag, but to keep on top of the stable tree > emails to stop patches being backported that don't need to be. > > If you still want me to remove it, I will, but I predict it will still > be backported. Fair, but the argument is not very... "clean", if you will. I read the argument as "the unwelcome thing is likely to happen anyway, so doesn't matter". But Fixes serves no purpose here, since we don't expect the backport. So we are defaulting to adding something useless on the basis of it not making things worse? I'm only saying that to make sure I understand your perspective. Obviously not something I'd hold your patches over, fine either way.