From: Jakub Kicinski <kuba@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
netdev@vger.kernel.org, magnus.karlsson@intel.com,
bjorn@kernel.org, Alexandr Lobakin <alexandr.lobakin@intel.com>
Subject: Re: [PATCH v3 bpf-next 02/11] ice: allow toggling loopback mode via ndo_set_features callback
Date: Wed, 15 Jun 2022 16:50:00 -0700 [thread overview]
Message-ID: <20220615165000.4147cf57@kernel.org> (raw)
In-Reply-To: <20220615161041.902916-3-maciej.fijalkowski@intel.com>
On Wed, 15 Jun 2022 18:10:32 +0200 Maciej Fijalkowski wrote:
> + if (if_running)
> + ice_stop(netdev);
> + if (ice_aq_set_mac_loopback(hw, ena, NULL))
> + netdev_err(netdev, "Failed to toggle loopback state\n");
> + if (if_running)
> + ice_open(netdev);
Ay. Looks like I commented on previous version, same complaint.
next prev parent reply other threads:[~2022-06-15 23:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 16:10 [PATCH v3 bpf-next 00/11] AF_XDP ZC selftests Maciej Fijalkowski
2022-06-15 16:10 ` [PATCH v3 bpf-next 01/11] ice: compress branches in ice_set_features() Maciej Fijalkowski
2022-06-15 16:10 ` [PATCH v3 bpf-next 02/11] ice: allow toggling loopback mode via ndo_set_features callback Maciej Fijalkowski
2022-06-15 23:50 ` Jakub Kicinski [this message]
2022-06-15 16:10 ` [PATCH v3 bpf-next 03/11] ice: check DD bit on Rx descriptor rather than (EOP | RS) Maciej Fijalkowski
2022-06-15 16:10 ` [PATCH v3 bpf-next 04/11] ice: do not setup vlan for loopback VSI Maciej Fijalkowski
2022-06-15 16:10 ` [PATCH v3 bpf-next 05/11] selftests: xsk: query for native XDP support Maciej Fijalkowski
2022-06-15 16:10 ` [PATCH v3 bpf-next 06/11] selftests: xsk: add missing close() on netns fd Maciej Fijalkowski
2022-06-15 16:10 ` [PATCH v3 bpf-next 07/11] selftests: xsk: introduce default Rx pkt stream Maciej Fijalkowski
2022-06-15 16:10 ` [PATCH v3 bpf-next 08/11] selftests: xsk: add support for executing tests on physical device Maciej Fijalkowski
2022-06-15 16:10 ` [PATCH v3 bpf-next 09/11] selftests: xsk: rely on pkts_in_flight in wait_for_tx_completion() Maciej Fijalkowski
2022-06-15 16:10 ` [PATCH v3 bpf-next 10/11] selftests: xsk: remove struct xsk_socket_info::outstanding_tx Maciej Fijalkowski
2022-06-16 12:28 ` Magnus Karlsson
2022-06-15 16:10 ` [PATCH v3 bpf-next 11/11] selftests: xsk: add support for zero copy testing Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615165000.4147cf57@kernel.org \
--to=kuba@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).