From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D383C43334 for ; Thu, 16 Jun 2022 03:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355476AbiFPDFs (ORCPT ); Wed, 15 Jun 2022 23:05:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357429AbiFPDFr (ORCPT ); Wed, 15 Jun 2022 23:05:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F25D65A145; Wed, 15 Jun 2022 20:05:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D3B561408; Thu, 16 Jun 2022 03:05:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94177C3411A; Thu, 16 Jun 2022 03:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655348746; bh=eKMfwTswQ0hHiZwig2FzE3cqMfqaHWQ47VvrfOtn69Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VBis4LHJiUdLqv8ckZc82+pkTeCKeOfmmfcpWrguIjrUIs7IavQEIn8zUT/+RYDFt MvnJAEA4tTU1uArvetRT4CcbI88SmB0hR0Ko/yMJUhVea3l6qKIqklFDROgaGQrp0V 1JC1cbIIa2xckcS4TFVZAOpDc6JruTDghZ95cnSVlEjMi7+ID/YBku3Jpf9+LYLwXO VuA9dPXkwrqEqx79nImTYlwRf0dkic2GlewTvC+h/AWo8c+yhmkuN0dxogl2IQvtCN 7dLrWdadDa3PwEfdaKt7dHpM1BTFjvkW227RZSsSwKsrth7lL1J0tt10aSkaqJAfis GrQ9/VScI3s9A== Date: Wed, 15 Jun 2022 20:05:44 -0700 From: Jakub Kicinski To: Raju Lakkaraju Cc: , , , , , , , Subject: Re: [PATCH net-next V1 3/5] net: lan743x: Add support to SGMII block access functions Message-ID: <20220615200544.10399227@kernel.org> In-Reply-To: <20220615103237.3331-4-Raju.Lakkaraju@microchip.com> References: <20220615103237.3331-1-Raju.Lakkaraju@microchip.com> <20220615103237.3331-4-Raju.Lakkaraju@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 15 Jun 2022 16:02:35 +0530 Raju Lakkaraju wrote: > Subject: [PATCH net-next V1 3/5] net: lan743x: Add support to SGMII block access functions > > Add SGMII access read and write functions Unfortunately you can't define functions and use them in later patches. It will break build during bisection because of -Wunused-function now that the kernel defaults to -Werror. I say just squash this into the next patch, it's not that big.