From: Jakub Kicinski <kuba@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: HighW4y2H3ll <huzh@nyu.edu>, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix Fortify String build warnings caused by the memcpy check in hinic_devlink.c.
Date: Thu, 16 Jun 2022 20:24:45 -0700 [thread overview]
Message-ID: <20220616202445.559b95c9@kernel.org> (raw)
In-Reply-To: <20220616201216.2eefad10@hermes.local>
On Thu, 16 Jun 2022 20:12:16 -0700 Stephen Hemminger wrote:
> Patch is missing signed-of-by
>
> Using [0] inside union will cause warnings in future since you are referencing
> outside of bounds of array.
>
> Also indentation is wrong, you need to indent the union
BTW there's already a fix from Kees pending for this.
prev parent reply other threads:[~2022-06-17 3:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 23:57 [PATCH] Fix Fortify String build warnings caused by the memcpy check in hinic_devlink.c HighW4y2H3ll
2022-06-17 3:12 ` Stephen Hemminger
2022-06-17 3:24 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616202445.559b95c9@kernel.org \
--to=kuba@kernel.org \
--cc=huzh@nyu.edu \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).