netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Amit Shah <aams@amazon.com>,
	Kuniyuki Iwashima <kuniyu@amazon.com>,
	Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: [PATCH v1 net-next 3/6] af_unix: Define a per-netns hash table.
Date: Thu, 16 Jun 2022 16:47:11 -0700	[thread overview]
Message-ID: <20220616234714.4291-4-kuniyu@amazon.com> (raw)
In-Reply-To: <20220616234714.4291-1-kuniyu@amazon.com>

This commit adds a per netns hash table for AF_UNIX.

Note that its size is fixed as UNIX_HASH_SIZE for now.

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
 include/net/af_unix.h    |  5 +++++
 include/net/netns/unix.h |  2 ++
 net/unix/af_unix.c       | 40 ++++++++++++++++++++++++++++++++++------
 3 files changed, 41 insertions(+), 6 deletions(-)

diff --git a/include/net/af_unix.h b/include/net/af_unix.h
index acb56e463db1..0a17e49af0c9 100644
--- a/include/net/af_unix.h
+++ b/include/net/af_unix.h
@@ -24,6 +24,11 @@ extern unsigned int unix_tot_inflight;
 extern spinlock_t unix_table_locks[UNIX_HASH_SIZE];
 extern struct hlist_head unix_socket_table[UNIX_HASH_SIZE];
 
+struct unix_hashbucket {
+	spinlock_t		lock;
+	struct hlist_head	head;
+};
+
 struct unix_address {
 	refcount_t	refcnt;
 	int		len;
diff --git a/include/net/netns/unix.h b/include/net/netns/unix.h
index 91a3d7e39198..975c4e3f8a5b 100644
--- a/include/net/netns/unix.h
+++ b/include/net/netns/unix.h
@@ -5,8 +5,10 @@
 #ifndef __NETNS_UNIX_H__
 #define __NETNS_UNIX_H__
 
+struct unix_hashbucket;
 struct ctl_table_header;
 struct netns_unix {
+	struct unix_hashbucket	*hash;
 	int			sysctl_max_dgram_qlen;
 	struct ctl_table_header	*ctl;
 };
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index c0804ae9c96a..3c07702e2349 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -3559,7 +3559,7 @@ static const struct net_proto_family unix_family_ops = {
 
 static int __net_init unix_net_init(struct net *net)
 {
-	int error = -ENOMEM;
+	int i;
 
 	net->unx.sysctl_max_dgram_qlen = 10;
 	if (unix_sysctl_register(net))
@@ -3567,18 +3567,35 @@ static int __net_init unix_net_init(struct net *net)
 
 #ifdef CONFIG_PROC_FS
 	if (!proc_create_net("unix", 0, net->proc_net, &unix_seq_ops,
-			sizeof(struct seq_net_private))) {
-		unix_sysctl_unregister(net);
-		goto out;
+			     sizeof(struct seq_net_private)))
+		goto err_sysctl;
+#endif
+
+	net->unx.hash = kmalloc(sizeof(struct unix_hashbucket) * UNIX_HASH_SIZE,
+				GFP_KERNEL);
+	if (!net->unx.hash)
+		goto err_proc;
+
+	for (i = 0; i < UNIX_HASH_SIZE; i++) {
+		INIT_HLIST_HEAD(&net->unx.hash[i].head);
+		spin_lock_init(&net->unx.hash[i].lock);
 	}
+
+	return 0;
+
+err_proc:
+#ifdef CONFIG_PROC_FS
+	remove_proc_entry("unix", net->proc_net);
 #endif
-	error = 0;
+err_sysctl:
+	unix_sysctl_unregister(net);
 out:
-	return error;
+	return -ENOMEM;
 }
 
 static void __net_exit unix_net_exit(struct net *net)
 {
+	kfree(net->unx.hash);
 	unix_sysctl_unregister(net);
 	remove_proc_entry("unix", net->proc_net);
 }
@@ -3666,6 +3683,16 @@ static int __init af_unix_init(void)
 
 	BUILD_BUG_ON(sizeof(struct unix_skb_parms) > sizeof_field(struct sk_buff, cb));
 
+	init_net.unx.hash = kmalloc(sizeof(struct unix_hashbucket) * UNIX_HASH_SIZE,
+				    GFP_KERNEL);
+	if (!init_net.unx.hash)
+		goto out;
+
+	for (i = 0; i < UNIX_HASH_SIZE; i++) {
+		INIT_HLIST_HEAD(&init_net.unx.hash[i].head);
+		spin_lock_init(&init_net.unx.hash[i].lock);
+	}
+
 	for (i = 0; i < UNIX_HASH_SIZE; i++)
 		spin_lock_init(&unix_table_locks[i]);
 
@@ -3699,6 +3726,7 @@ static void __exit af_unix_exit(void)
 	proto_unregister(&unix_dgram_proto);
 	proto_unregister(&unix_stream_proto);
 	unregister_pernet_subsys(&unix_net_ops);
+	kfree(init_net.unx.hash);
 }
 
 /* Earlier than device_initcall() so that other drivers invoking
-- 
2.30.2


  parent reply	other threads:[~2022-06-16 23:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 23:47 [PATCH v1 net-next 0/6] af_unix: Introduce per-netns socket hash table Kuniyuki Iwashima
2022-06-16 23:47 ` [PATCH v1 net-next 1/6] af_unix: Clean up some sock_net() uses Kuniyuki Iwashima
2022-06-16 23:47 ` [PATCH v1 net-next 2/6] af_unix: Include the whole hash table size in UNIX_HASH_SIZE Kuniyuki Iwashima
2022-06-16 23:47 ` Kuniyuki Iwashima [this message]
2022-06-17  4:23   ` [PATCH v1 net-next 3/6] af_unix: Define a per-netns hash table Eric Dumazet
2022-06-17  5:33     ` Kuniyuki Iwashima
2022-06-17  6:08       ` Eric Dumazet
2022-06-17  6:57         ` Kuniyuki Iwashima
2022-06-17  8:00           ` Eric Dumazet
2022-06-17 17:52             ` Kuniyuki Iwashima
2022-06-17 18:17   ` kernel test robot
2022-06-17 20:44     ` Kuniyuki Iwashima
2022-06-16 23:47 ` [PATCH v1 net-next 4/6] af_unix: Acquire/Release per-netns hash table's locks Kuniyuki Iwashima
2022-06-20  6:10   ` [af_unix] b4813d5914: WARNING:possible_recursive_locking_detected kernel test robot
2022-06-20 16:47     ` Kuniyuki Iwashima
2022-06-16 23:47 ` [PATCH v1 net-next 5/6] af_unix: Put a socket into a per-netns hash table Kuniyuki Iwashima
2022-06-16 23:47 ` [PATCH v1 net-next 6/6] af_unix: Remove unix_table_locks Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220616234714.4291-4-kuniyu@amazon.com \
    --to=kuniyu@amazon.com \
    --cc=aams@amazon.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).