From: Marcin Wojtas <mw@semihalf.com>
To: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
netdev@vger.kernel.org
Cc: rafael@kernel.org, andriy.shevchenko@linux.intel.com,
lenb@kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux@armlinux.org.uk, hkallweit1@gmail.com, gjb@semihalf.com,
mw@semihalf.com, jaz@semihalf.com, tn@semihalf.com,
Samer.El-Haj-Mahmoud@arm.com, upstream@semihalf.com
Subject: [net-next: PATCH 12/12] net: dsa: mv88e6xxx: add ACPI support
Date: Mon, 20 Jun 2022 17:02:25 +0200 [thread overview]
Message-ID: <20220620150225.1307946-13-mw@semihalf.com> (raw)
In-Reply-To: <20220620150225.1307946-1-mw@semihalf.com>
Previous patches dropped the strict dependency on the OF_* API
in both generic DSA subsystem and the mv88e6xxx driver.
As a result the ACPI support can be introduced by adding
the necessary ID's in the acpi_match_table and a two
minor required adjustments, i.e. different mdiobus registration
and MDIO subnode name, so to conform ACPI namespace requirements [1].
[1] https://uefi.org/specs/ACPI/6.4/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#acpi-namespace
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
drivers/net/dsa/mv88e6xxx/chip.c | 25 ++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 556defa4379d..a74e528184aa 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -10,6 +10,8 @@
* Vivien Didelot <vivien.didelot@savoirfairelinux.com>
*/
+#include <linux/acpi.h>
+#include <linux/acpi_mdio.h>
#include <linux/bitfield.h>
#include <linux/delay.h>
#include <linux/dsa/mv88e6xxx.h>
@@ -3913,7 +3915,10 @@ static int mv88e6xxx_mdio_register(struct mv88e6xxx_chip *chip,
goto out;
}
- err = of_mdiobus_register(bus, np);
+ if (is_acpi_node(fwnode))
+ err = acpi_mdiobus_register(bus, fwnode);
+ else
+ err = of_mdiobus_register(bus, np);
if (err) {
dev_err(chip->dev, "Cannot register MDIO bus (%d)\n", err);
mv88e6xxx_g2_irq_mdio_free(chip, bus);
@@ -3952,14 +3957,19 @@ static void mv88e6xxx_mdios_unregister(struct mv88e6xxx_chip *chip)
static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip,
struct fwnode_handle *fwnode)
{
+ char mdio_node_name[] = "mdio";
struct fwnode_handle *child;
int err;
+ /* Update subnode name if operating in the ACPI world. */
+ if (is_acpi_node(fwnode))
+ strncpy(mdio_node_name, "MDIO", ACPI_NAMESEG_SIZE);
+
/* Always register one mdio bus for the internal/default mdio
* bus. This maybe represented in the device tree, but is
* optional.
*/
- child = fwnode_get_named_child_node(fwnode, "mdio");
+ child = fwnode_get_named_child_node(fwnode, mdio_node_name);
err = mv88e6xxx_mdio_register(chip, child, false);
fwnode_handle_put(child);
if (err)
@@ -7177,6 +7187,16 @@ static const struct of_device_id mv88e6xxx_of_match[] = {
MODULE_DEVICE_TABLE(of, mv88e6xxx_of_match);
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id sdhci_mv88e6xxx_acpi_ids[] = {
+ { .id = "MRVL0120", (kernel_ulong_t)&mv88e6xxx_table[MV88E6085]},
+ { .id = "MRVL0121", (kernel_ulong_t)&mv88e6xxx_table[MV88E6190]},
+ { .id = "MRVL0122", (kernel_ulong_t)&mv88e6xxx_table[MV88E6250]},
+ {}
+};
+MODULE_DEVICE_TABLE(acpi, sdhci_mv88e6xxx_acpi_ids);
+#endif
+
static struct mdio_driver mv88e6xxx_driver = {
.probe = mv88e6xxx_probe,
.remove = mv88e6xxx_remove,
@@ -7184,6 +7204,7 @@ static struct mdio_driver mv88e6xxx_driver = {
.mdiodrv.driver = {
.name = "mv88e6085",
.of_match_table = mv88e6xxx_of_match,
+ .acpi_match_table = ACPI_PTR(sdhci_mv88e6xxx_acpi_ids),
.pm = &mv88e6xxx_pm_ops,
},
};
--
2.29.0
next prev parent reply other threads:[~2022-06-20 15:14 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 15:02 [net-next: PATCH 00/12] ACPI support for DSA Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 01/12] net: phy: fixed_phy: switch to fwnode_ API Marcin Wojtas
2022-06-20 17:25 ` Andy Shevchenko
2022-06-20 17:59 ` Andrew Lunn
2022-06-21 9:56 ` Marcin Wojtas
2022-06-21 10:01 ` Russell King (Oracle)
2022-06-20 15:02 ` [net-next: PATCH 02/12] net: mdio: switch fixed-link PHYs API to fwnode_ Marcin Wojtas
2022-06-20 17:32 ` Andy Shevchenko
2022-06-21 9:22 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 03/12] net: dsa: switch to device_/fwnode_ APIs Marcin Wojtas
2022-06-20 17:41 ` Andy Shevchenko
2022-06-21 9:27 ` Marcin Wojtas
2022-06-21 11:02 ` Andy Shevchenko
2022-06-22 16:09 ` Florian Fainelli
2022-06-20 15:02 ` [net-next: PATCH 04/12] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2022-06-20 17:43 ` Andy Shevchenko
2022-06-20 17:44 ` Andy Shevchenko
2022-06-21 9:28 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 05/12] net: core: switch to fwnode_find_net_device_by_node() Marcin Wojtas
2022-06-20 17:46 ` Andy Shevchenko
2022-06-20 23:15 ` Marcin Wojtas
2022-06-20 22:30 ` kernel test robot
2022-06-20 15:02 ` [net-next: PATCH 06/12] net: mdio: introduce fwnode_mdiobus_register_device() Marcin Wojtas
2022-06-20 17:48 ` Andy Shevchenko
2022-06-21 9:33 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 07/12] net: mdio: allow registering non-PHY devices in ACPI world Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 08/12] ACPI: scan: prevent double enumeration of MDIO bus children Marcin Wojtas
2022-06-20 17:53 ` Andy Shevchenko
2022-06-20 23:04 ` Marcin Wojtas
2022-06-22 12:09 ` Rafael J. Wysocki
2022-06-22 15:05 ` Marcin Wojtas
2022-06-20 19:08 ` Andrew Lunn
2022-06-22 12:05 ` Rafael J. Wysocki
2022-06-22 16:12 ` Florian Fainelli
2022-06-22 16:21 ` Rafael J. Wysocki
2022-06-23 7:41 ` Andrew Lunn
2022-06-23 23:07 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 09/12] Documentation: ACPI: DSD: introduce DSA description Marcin Wojtas
2022-06-20 18:19 ` Andrew Lunn
2022-06-20 23:21 ` Marcin Wojtas
2022-06-20 19:47 ` Andrew Lunn
2022-06-20 23:25 ` Marcin Wojtas
2022-06-21 11:09 ` Andy Shevchenko
2022-06-21 11:18 ` Andrew Lunn
2022-06-21 11:42 ` Andy Shevchenko
2022-06-22 9:08 ` Marcin Wojtas
2022-06-22 9:24 ` Andrew Lunn
2022-06-22 10:22 ` Marcin Wojtas
2022-06-22 10:37 ` Andrew Lunn
2022-06-22 11:08 ` Andy Shevchenko
2022-06-22 11:04 ` Andy Shevchenko
2022-06-22 11:03 ` Andy Shevchenko
2022-06-22 11:22 ` Andrew Lunn
2022-06-22 14:20 ` Andy Shevchenko
2022-06-22 15:00 ` Marcin Wojtas
2022-06-21 9:45 ` Sudeep Holla
2022-06-21 11:15 ` Andy Shevchenko
2022-06-21 11:24 ` Andrew Lunn
2022-06-21 11:46 ` Andy Shevchenko
2022-06-21 11:57 ` Andrew Lunn
2022-06-21 13:28 ` Sudeep Holla
2022-06-21 15:23 ` Rafael J. Wysocki
2022-06-21 15:37 ` Sudeep Holla
2022-06-21 16:00 ` Rafael J. Wysocki
2022-06-21 18:11 ` Sudeep Holla
2022-06-20 15:02 ` [net-next: PATCH 10/12] net: dsa: add ACPI support Marcin Wojtas
2022-06-20 18:32 ` Andrew Lunn
2022-06-20 23:31 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 11/12] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs Marcin Wojtas
2022-06-20 18:00 ` Andy Shevchenko
2022-06-21 9:14 ` Marcin Wojtas
2022-06-20 18:04 ` Andy Shevchenko
2022-06-21 9:15 ` Marcin Wojtas
2022-06-20 15:02 ` Marcin Wojtas [this message]
2022-06-25 2:54 ` [net-next: PATCH 12/12] net: dsa: mv88e6xxx: add ACPI support kernel test robot
2022-06-20 17:21 ` [net-next: PATCH 00/12] ACPI support for DSA Andy Shevchenko
2022-06-21 10:02 ` Marcin Wojtas
2022-06-20 17:55 ` Andrew Lunn
2022-06-20 18:07 ` Andy Shevchenko
2022-06-20 18:45 ` Andrew Lunn
2022-06-21 10:46 ` Marcin Wojtas
2022-06-22 15:40 ` Marcin Wojtas
2022-06-22 16:14 ` Andy Shevchenko
2022-06-21 10:16 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620150225.1307946-13-mw@semihalf.com \
--to=mw@semihalf.com \
--cc=Samer.El-Haj-Mahmoud@arm.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gjb@semihalf.com \
--cc=hkallweit1@gmail.com \
--cc=jaz@semihalf.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=tn@semihalf.com \
--cc=upstream@semihalf.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).