netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	netdev@vger.kernel.org
Cc: rafael@kernel.org, andriy.shevchenko@linux.intel.com,
	lenb@kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com,
	f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	linux@armlinux.org.uk, hkallweit1@gmail.com, gjb@semihalf.com,
	mw@semihalf.com, jaz@semihalf.com, tn@semihalf.com,
	Samer.El-Haj-Mahmoud@arm.com, upstream@semihalf.com
Subject: [net-next: PATCH 08/12] ACPI: scan: prevent double enumeration of MDIO bus children
Date: Mon, 20 Jun 2022 17:02:21 +0200	[thread overview]
Message-ID: <20220620150225.1307946-9-mw@semihalf.com> (raw)
In-Reply-To: <20220620150225.1307946-1-mw@semihalf.com>

The MDIO bus is responsible for probing and registering its respective
children, such as PHYs or other kind of devices.

It is required that ACPI scan code should not enumerate such
devices, leaving this task for the generic MDIO bus routines,
which are initiated by the controller driver.

This patch prevents unwanted enumeration of the devices by setting
'enumeration_by_parent' flag, depending on whether their parent
device is a member of a known list of MDIO controllers. For now,
the Marvell MDIO controllers' IDs are added.

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 drivers/acpi/scan.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 762b61f67e6c..d703c35dc218 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -1716,6 +1716,18 @@ static bool acpi_is_indirect_io_slave(struct acpi_device *device)
 	return parent && !acpi_match_device_ids(parent, indirect_io_hosts);
 }
 
+static bool acpi_is_mdio_child(struct acpi_device *device)
+{
+	struct acpi_device *parent = device->parent;
+	static const struct acpi_device_id mdio_controllers[] = {
+		{"MRVL0100", 0},
+		{"MRVL0101", 0},
+		{}
+	};
+
+	return parent && !acpi_match_device_ids(parent, mdio_controllers);
+}
+
 static bool acpi_device_enumeration_by_parent(struct acpi_device *device)
 {
 	struct list_head resource_list;
@@ -1756,6 +1768,9 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device)
 	if (acpi_is_indirect_io_slave(device))
 		return true;
 
+	if (acpi_is_mdio_child(device))
+		return true;
+
 	/* Macs use device properties in lieu of _CRS resources */
 	if (x86_apple_machine &&
 	    (fwnode_property_present(&device->fwnode, "spiSclkPeriod") ||
-- 
2.29.0


  parent reply	other threads:[~2022-06-20 15:12 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20 15:02 [net-next: PATCH 00/12] ACPI support for DSA Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 01/12] net: phy: fixed_phy: switch to fwnode_ API Marcin Wojtas
2022-06-20 17:25   ` Andy Shevchenko
2022-06-20 17:59   ` Andrew Lunn
2022-06-21  9:56     ` Marcin Wojtas
2022-06-21 10:01       ` Russell King (Oracle)
2022-06-20 15:02 ` [net-next: PATCH 02/12] net: mdio: switch fixed-link PHYs API to fwnode_ Marcin Wojtas
2022-06-20 17:32   ` Andy Shevchenko
2022-06-21  9:22     ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 03/12] net: dsa: switch to device_/fwnode_ APIs Marcin Wojtas
2022-06-20 17:41   ` Andy Shevchenko
2022-06-21  9:27     ` Marcin Wojtas
2022-06-21 11:02       ` Andy Shevchenko
2022-06-22 16:09         ` Florian Fainelli
2022-06-20 15:02 ` [net-next: PATCH 04/12] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2022-06-20 17:43   ` Andy Shevchenko
2022-06-20 17:44     ` Andy Shevchenko
2022-06-21  9:28       ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 05/12] net: core: switch to fwnode_find_net_device_by_node() Marcin Wojtas
2022-06-20 17:46   ` Andy Shevchenko
2022-06-20 23:15     ` Marcin Wojtas
2022-06-20 22:30   ` kernel test robot
2022-06-20 15:02 ` [net-next: PATCH 06/12] net: mdio: introduce fwnode_mdiobus_register_device() Marcin Wojtas
2022-06-20 17:48   ` Andy Shevchenko
2022-06-21  9:33     ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 07/12] net: mdio: allow registering non-PHY devices in ACPI world Marcin Wojtas
2022-06-20 15:02 ` Marcin Wojtas [this message]
2022-06-20 17:53   ` [net-next: PATCH 08/12] ACPI: scan: prevent double enumeration of MDIO bus children Andy Shevchenko
2022-06-20 23:04     ` Marcin Wojtas
2022-06-22 12:09       ` Rafael J. Wysocki
2022-06-22 15:05         ` Marcin Wojtas
2022-06-20 19:08   ` Andrew Lunn
2022-06-22 12:05     ` Rafael J. Wysocki
2022-06-22 16:12       ` Florian Fainelli
2022-06-22 16:21         ` Rafael J. Wysocki
2022-06-23  7:41           ` Andrew Lunn
2022-06-23 23:07             ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 09/12] Documentation: ACPI: DSD: introduce DSA description Marcin Wojtas
2022-06-20 18:19   ` Andrew Lunn
2022-06-20 23:21     ` Marcin Wojtas
2022-06-20 19:47   ` Andrew Lunn
2022-06-20 23:25     ` Marcin Wojtas
2022-06-21 11:09     ` Andy Shevchenko
2022-06-21 11:18       ` Andrew Lunn
2022-06-21 11:42         ` Andy Shevchenko
2022-06-22  9:08           ` Marcin Wojtas
2022-06-22  9:24             ` Andrew Lunn
2022-06-22 10:22               ` Marcin Wojtas
2022-06-22 10:37                 ` Andrew Lunn
2022-06-22 11:08                   ` Andy Shevchenko
2022-06-22 11:04               ` Andy Shevchenko
2022-06-22 11:03             ` Andy Shevchenko
2022-06-22 11:22               ` Andrew Lunn
2022-06-22 14:20                 ` Andy Shevchenko
2022-06-22 15:00                   ` Marcin Wojtas
2022-06-21  9:45   ` Sudeep Holla
2022-06-21 11:15     ` Andy Shevchenko
2022-06-21 11:24       ` Andrew Lunn
2022-06-21 11:46         ` Andy Shevchenko
2022-06-21 11:57           ` Andrew Lunn
2022-06-21 13:28         ` Sudeep Holla
2022-06-21 15:23           ` Rafael J. Wysocki
2022-06-21 15:37             ` Sudeep Holla
2022-06-21 16:00               ` Rafael J. Wysocki
2022-06-21 18:11                 ` Sudeep Holla
2022-06-20 15:02 ` [net-next: PATCH 10/12] net: dsa: add ACPI support Marcin Wojtas
2022-06-20 18:32   ` Andrew Lunn
2022-06-20 23:31     ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 11/12] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs Marcin Wojtas
2022-06-20 18:00   ` Andy Shevchenko
2022-06-21  9:14     ` Marcin Wojtas
2022-06-20 18:04   ` Andy Shevchenko
2022-06-21  9:15     ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 12/12] net: dsa: mv88e6xxx: add ACPI support Marcin Wojtas
2022-06-25  2:54   ` kernel test robot
2022-06-20 17:21 ` [net-next: PATCH 00/12] ACPI support for DSA Andy Shevchenko
2022-06-21 10:02   ` Marcin Wojtas
2022-06-20 17:55 ` Andrew Lunn
2022-06-20 18:07   ` Andy Shevchenko
2022-06-20 18:45     ` Andrew Lunn
2022-06-21 10:46       ` Marcin Wojtas
2022-06-22 15:40         ` Marcin Wojtas
2022-06-22 16:14           ` Andy Shevchenko
2022-06-21 10:16   ` Marcin Wojtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220620150225.1307946-9-mw@semihalf.com \
    --to=mw@semihalf.com \
    --cc=Samer.El-Haj-Mahmoud@arm.com \
    --cc=andrew@lunn.ch \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=gjb@semihalf.com \
    --cc=hkallweit1@gmail.com \
    --cc=jaz@semihalf.com \
    --cc=kuba@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=tn@semihalf.com \
    --cc=upstream@semihalf.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).