From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1025CCA473 for ; Tue, 21 Jun 2022 04:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344398AbiFUEre (ORCPT ); Tue, 21 Jun 2022 00:47:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230262AbiFUErc (ORCPT ); Tue, 21 Jun 2022 00:47:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 459DE183B3 for ; Mon, 20 Jun 2022 21:47:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9703060DF7 for ; Tue, 21 Jun 2022 04:47:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9FAEC3411D; Tue, 21 Jun 2022 04:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655786839; bh=2Un33cgWUTTy10j5hYwxQDoeBlf4PdwmIZEQ1NKZoWY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VEq3vgsKg0F/jOx5n20M2e91hJaZ5eF2LxrdtEwWo8fuQPySspnOZ3iBhtczt3CWR AknCq2Z/z4I7ZOZDMW9XOSB9EWoJYIb55QAC5JTYy9TtsXnMuYDjigR9W1rM/zdcU2 5Pb4VnFB+KKVPz2g2esfwra8seu16Uy/O1pPf8sIfoZPSn7uHb8bsP9Deo5aKJwptL Z1fQcxcAAeNDIdvPe54iEGYOUOAHlDRaTllOEeeIf3E6F6EwtZksjdDoqvSB6fenVZ vFUH9Up3+E+lVaB+SoinEUrDeJpOShV3jWIFoiTm2COAlzPShj3hEP+U0vaD4HfXJP oW/EKnT+I1Kqg== Date: Mon, 20 Jun 2022 21:47:17 -0700 From: Jakub Kicinski To: Simon Horman Cc: David Miller , Paolo Abeni , netdev@vger.kernel.org, oss-drivers@corigine.com, Yu Xiao Subject: Re: [PATCH net-next] nfp: compose firmware file name with new hwinfo "nffw.partno" Message-ID: <20220620214717.71537153@kernel.org> In-Reply-To: <20220620103912.46164-1-simon.horman@corigine.com> References: <20220620103912.46164-1-simon.horman@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 20 Jun 2022 12:39:12 +0200 Simon Horman wrote: > From: Yu Xiao > > During initialization of the NFP driver, a file name for loading > application firmware is composed using the NIC's AMDA information and port > type (count and speed). E.g.: "nic_AMDA0145-1012_2x10.nffw". > > In practice there may be many variants for each NIC type, and many of the > variants relate to assembly components which do not concern the driver and > application firmware implementation. Yet the current scheme leads to a > different application firmware file name for each variant, because they > have different AMDA information. > > To reduce proliferation of content-duplicated application firmware images > or symlinks, the NIC's management firmware will only expose differences > between variants that need different application firmware via a newly > introduced hwinfo, "nffw.partno". > > Use of the existing hwinfo, "assembly.partno", is maintained in order to > support for NICs with management firmware that does not expose > "nffw.partno". > > Signed-off-by: Yu Xiao > Signed-off-by: Simon Horman FWIW: Reviewed-by: Jakub Kicinski