From: kernel test robot <lkp@intel.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
Amit Shah <aams@amazon.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>
Subject: Re: [PATCH v2 net-next 6/6] af_unix: Remove unix_table_locks.
Date: Tue, 21 Jun 2022 05:39:37 +0800 [thread overview]
Message-ID: <202206210532.q32y1W52-lkp@intel.com> (raw)
In-Reply-To: <20220620185151.65294-7-kuniyu@amazon.com>
Hi Kuniyuki,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220621-025503
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dbca1596bbb08318f5e3b3b99f8ca0a0d3830a65
config: arc-defconfig (https://download.01.org/0day-ci/archive/20220621/202206210532.q32y1W52-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/f2cd3aee6929543114a0728717969d9bb2f6fa90
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220621-025503
git checkout f2cd3aee6929543114a0728717969d9bb2f6fa90
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/unix/diag.c: In function 'unix_lookup_by_ino':
>> net/unix/diag.c:247:46: error: 'unix_table_locks' undeclared (first use in this function); did you mean 'unix_state_lock'?
247 | spin_unlock(&unix_table_locks[i]);
| ^~~~~~~~~~~~~~~~
| unix_state_lock
net/unix/diag.c:247:46: note: each undeclared identifier is reported only once for each function it appears in
vim +247 net/unix/diag.c
22931d3b906cd0 Pavel Emelyanov 2011-12-15 235
a50feb1de03567 Kuniyuki Iwashima 2022-06-20 236 static struct sock *unix_lookup_by_ino(struct net *net, unsigned int ino)
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 237 {
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 238 struct sock *sk;
afd20b9290e184 Kuniyuki Iwashima 2021-11-24 239 int i;
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 240
614d83f20d005b Kuniyuki Iwashima 2022-06-20 241 for (i = 0; i < UNIX_HASH_SIZE; i++) {
a50feb1de03567 Kuniyuki Iwashima 2022-06-20 242 spin_lock(&net->unx.table.locks[i]);
868a38bbd9ad2a Kuniyuki Iwashima 2022-06-20 243 sk_for_each(sk, &net->unx.table.buckets[i]) {
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 244 if (ino == sock_i_ino(sk)) {
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 245 sock_hold(sk);
a50feb1de03567 Kuniyuki Iwashima 2022-06-20 246 spin_unlock(&net->unx.table.locks[i]);
afd20b9290e184 Kuniyuki Iwashima 2021-11-24 @247 spin_unlock(&unix_table_locks[i]);
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 248 return sk;
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 249 }
868a38bbd9ad2a Kuniyuki Iwashima 2022-06-20 250 }
a50feb1de03567 Kuniyuki Iwashima 2022-06-20 251 spin_unlock(&net->unx.table.locks[i]);
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 252 }
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 253 return NULL;
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 254 }
5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 255
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-06-20 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 18:51 [PATCH v2 net-next 0/6] af_unix: Introduce per-netns socket hash table Kuniyuki Iwashima
2022-06-20 18:51 ` [PATCH v2 net-next 1/6] af_unix: Clean up some sock_net() uses Kuniyuki Iwashima
2022-06-20 18:51 ` [PATCH v2 net-next 2/6] af_unix: Include the whole hash table size in UNIX_HASH_SIZE Kuniyuki Iwashima
2022-06-20 18:51 ` [PATCH v2 net-next 3/6] af_unix: Define a per-netns hash table Kuniyuki Iwashima
2022-06-20 18:51 ` [PATCH v2 net-next 4/6] af_unix: Acquire/Release per-netns hash table's locks Kuniyuki Iwashima
2022-06-20 18:51 ` [PATCH v2 net-next 5/6] af_unix: Put a socket into a per-netns hash table Kuniyuki Iwashima
2022-06-20 18:51 ` [PATCH v2 net-next 6/6] af_unix: Remove unix_table_locks Kuniyuki Iwashima
2022-06-20 21:39 ` kernel test robot [this message]
2022-06-20 21:53 ` Kuniyuki Iwashima
2022-06-20 21:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202206210532.q32y1W52-lkp@intel.com \
--to=lkp@intel.com \
--cc=aams@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).