From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6ACC43334 for ; Mon, 20 Jun 2022 21:40:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244791AbiFTVkN (ORCPT ); Mon, 20 Jun 2022 17:40:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240545AbiFTVkM (ORCPT ); Mon, 20 Jun 2022 17:40:12 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07AD61FA50 for ; Mon, 20 Jun 2022 14:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655761212; x=1687297212; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vYqJnP46zMKoAjtQpqP+WAvzi2m31ErjcpHAg81kyuc=; b=FKbVb3BI4nRkukfew9gsWeI299mFyfmF8WtwP8KyGMr6pHkAdq4si8Z6 EtNz5oqMKVzbE8Rg/EIexU/Wo3bITnV2lGKrXq3c1bbSGi4RTtdug6xIE 7LVv+mSCzcN5lf6y5dExDAaww8aixk6Ax8IIDWwyKZrpkn3RmWtCu0TTd DfCZOUkpHzgcROVoT4/NGrXsgOh4HA56uf4zKQgxPseQbyHTftufec6hz +UPhBsXls3dYTpYMTOxSkwpP4jG/qj7AiOslpkZvS/hzbYxNPDib7qMNR aYjLQM86lujwXbZaMG77RCs3lp2oDmpnEBfzcfDftg+DW0fHEmdoCTSgb g==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="268697485" X-IronPort-AV: E=Sophos;i="5.92,207,1650956400"; d="scan'208";a="268697485" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 14:40:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,207,1650956400"; d="scan'208";a="913835212" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 20 Jun 2022 14:40:09 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o3P7r-000WNt-OD; Mon, 20 Jun 2022 21:40:03 +0000 Date: Tue, 21 Jun 2022 05:39:40 +0800 From: kernel test robot To: Kuniyuki Iwashima , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, netdev@vger.kernel.org, Amit Shah , Kuniyuki Iwashima Subject: Re: [PATCH v2 net-next 6/6] af_unix: Remove unix_table_locks. Message-ID: <202206210554.YYgdQz8e-lkp@intel.com> References: <20220620185151.65294-7-kuniyu@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220620185151.65294-7-kuniyu@amazon.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Kuniyuki, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220621-025503 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dbca1596bbb08318f5e3b3b99f8ca0a0d3830a65 config: i386-randconfig-a012-20220620 (https://download.01.org/0day-ci/archive/20220621/202206210554.YYgdQz8e-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af6d2a0b6825e71965f3e2701a63c239fa0ad70f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f2cd3aee6929543114a0728717969d9bb2f6fa90 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220621-025503 git checkout f2cd3aee6929543114a0728717969d9bb2f6fa90 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> net/unix/diag.c:247:18: error: use of undeclared identifier 'unix_table_locks' spin_unlock(&unix_table_locks[i]); ^ 1 error generated. vim +/unix_table_locks +247 net/unix/diag.c 22931d3b906cd0 Pavel Emelyanov 2011-12-15 235 a50feb1de03567 Kuniyuki Iwashima 2022-06-20 236 static struct sock *unix_lookup_by_ino(struct net *net, unsigned int ino) 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 237 { 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 238 struct sock *sk; afd20b9290e184 Kuniyuki Iwashima 2021-11-24 239 int i; 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 240 614d83f20d005b Kuniyuki Iwashima 2022-06-20 241 for (i = 0; i < UNIX_HASH_SIZE; i++) { a50feb1de03567 Kuniyuki Iwashima 2022-06-20 242 spin_lock(&net->unx.table.locks[i]); 868a38bbd9ad2a Kuniyuki Iwashima 2022-06-20 243 sk_for_each(sk, &net->unx.table.buckets[i]) { 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 244 if (ino == sock_i_ino(sk)) { 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 245 sock_hold(sk); a50feb1de03567 Kuniyuki Iwashima 2022-06-20 246 spin_unlock(&net->unx.table.locks[i]); afd20b9290e184 Kuniyuki Iwashima 2021-11-24 @247 spin_unlock(&unix_table_locks[i]); 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 248 return sk; 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 249 } 868a38bbd9ad2a Kuniyuki Iwashima 2022-06-20 250 } a50feb1de03567 Kuniyuki Iwashima 2022-06-20 251 spin_unlock(&net->unx.table.locks[i]); 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 252 } 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 253 return NULL; 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 254 } 5d3cae8bc39dd3 Pavel Emelyanov 2011-12-15 255 -- 0-DAY CI Kernel Test Service https://01.org/lkp