From: Jakub Kicinski <kuba@kernel.org>
To: Martin Habets <habetsm.xilinx@gmail.com>
Cc: jonathan.s.cooper@amd.com, davem@davemloft.net,
pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org,
ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next 8/8] sfc: Separate netdev probe/remove from PCI probe/remove
Date: Tue, 21 Jun 2022 22:09:55 -0700 [thread overview]
Message-ID: <20220621220955.73e4e1fc@kernel.org> (raw)
In-Reply-To: <165573359154.2982.3558513705929382829.stgit@palantir17.mph.net>
On Mon, 20 Jun 2022 14:59:51 +0100 Martin Habets wrote:
> From: Jonathan Cooper <jonathan.s.cooper@amd.com>
>
> The netdev probe will be used when moving from the vDPA to EF100 BAR config.
> The netdev remove will be used when moving from the EF100 to vDPA BAR config.
>
> In the process, change several log messages to pci_ instead of netif_
> to remove the "(unregistered net_device)" text.
The patches LGTM, but this one needs to get checkpatch'ed.
Whitespace is off. Sorry for not catching this earlier.
Consider switching from the non-standard Co-authored-by
to Co-developed-by for extra points.
prev parent reply other threads:[~2022-06-22 5:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 13:58 [PATCH net-next 0/8] sfc: Add extra states for VDPA Martin Habets
2022-06-20 13:58 ` [PATCH net-next 1/8] sfc: Split STATE_READY in to STATE_NET_DOWN and STATE_NET_UP Martin Habets
2022-06-20 13:58 ` [PATCH net-next 2/8] sfc: Add a PROBED state for EF100 VDPA use Martin Habets
2022-06-20 13:58 ` [PATCH net-next 3/8] sfc: Remove netdev init from efx_init_struct Martin Habets
2022-06-20 13:59 ` [PATCH net-next 4/8] sfc: Encapsulate access to netdev_priv() Martin Habets
2022-06-20 13:59 ` [PATCH net-next 5/8] sfc: Fix checkpatch warning Martin Habets
2022-06-20 13:59 ` [PATCH net-next 6/8] sfc: Separate efx_nic memory from net_device memory Martin Habets
2022-06-20 13:59 ` [PATCH net-next 7/8] sfc: Move EF100 efx_nic_type structs to the end of the file Martin Habets
2022-06-20 13:59 ` [PATCH net-next 8/8] sfc: Separate netdev probe/remove from PCI probe/remove Martin Habets
2022-06-22 5:09 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621220955.73e4e1fc@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=jonathan.s.cooper@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).