From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FA3C433EF for ; Wed, 22 Jun 2022 05:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356400AbiFVFJ7 (ORCPT ); Wed, 22 Jun 2022 01:09:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347664AbiFVFJ6 (ORCPT ); Wed, 22 Jun 2022 01:09:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36D1035879 for ; Tue, 21 Jun 2022 22:09:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6C3361977 for ; Wed, 22 Jun 2022 05:09:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB421C34114; Wed, 22 Jun 2022 05:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655874597; bh=+1in/MPKviwhy0mCQPh86vDrJSdJKiMdmjEoto5/HEo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=k4a6HWhJtMie+lTcdXHlON6dlPHXHlU75Jc076C0WbPNXgWdjZA9VjFdciFGi7hbQ K5Fkh+VawHAM3geaWAHaSKSYKe9v7QzTzIIvbYdgnGC2mZ+8pUUPqw0wCORNmfqSab TPK69d2Ua7Q/+3i3zXJJV6CDfMK17Kt+JUCaI2TIh2SXudjqIMjilDgFV6TFjK+LTT QD7Xte9eleHkHOViQ1GoE+BkKqoxGcdbqAHLRWAkWoU0qL4Sikq/64hmhskL1qNVKV RGDvy9tZ5ROZUqWBZlW8dU7zKh/3FUQtoQBz8V0dj4FBTn69UX0qzdDTGlygscZzqS gCj3Q/HLw0Llg== Date: Tue, 21 Jun 2022 22:09:55 -0700 From: Jakub Kicinski To: Martin Habets Cc: jonathan.s.cooper@amd.com, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, ecree.xilinx@gmail.com Subject: Re: [PATCH net-next 8/8] sfc: Separate netdev probe/remove from PCI probe/remove Message-ID: <20220621220955.73e4e1fc@kernel.org> In-Reply-To: <165573359154.2982.3558513705929382829.stgit@palantir17.mph.net> References: <165573340676.2982.8456666672406894221.stgit@palantir17.mph.net> <165573359154.2982.3558513705929382829.stgit@palantir17.mph.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 20 Jun 2022 14:59:51 +0100 Martin Habets wrote: > From: Jonathan Cooper > > The netdev probe will be used when moving from the vDPA to EF100 BAR config. > The netdev remove will be used when moving from the EF100 to vDPA BAR config. > > In the process, change several log messages to pci_ instead of netif_ > to remove the "(unregistered net_device)" text. The patches LGTM, but this one needs to get checkpatch'ed. Whitespace is off. Sorry for not catching this earlier. Consider switching from the non-standard Co-authored-by to Co-developed-by for extra points.