From: Jakub Kicinski <kuba@kernel.org>
To: Arthur Gautier <baloo@superbaloo.net>
Cc: Raju Rangoju <rajur@chelsio.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb4: DOM support when using a QSFP to SFP adaptor
Date: Tue, 21 Jun 2022 22:23:17 -0700 [thread overview]
Message-ID: <20220621222317.1cbcaaeb@kernel.org> (raw)
In-Reply-To: <20220620223234.2443179-1-baloo@superbaloo.net>
On Mon, 20 Jun 2022 22:32:34 +0000 Arthur Gautier wrote:
> When a QSFP to SFP adaptor is used, the DOM eeprom is then presented
> with the SFF-8472 layout and not translated to SFF-8636 format.
>
> When parsing the eeprom, we can't just read the type of port but we
> need to identify the type of transceiver instead.
>
> Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
> Cc: Raju Rangoju <rajur@chelsio.com>
> Cc: netdev@vger.kernel.org
Makes sense. Do you expect this change to make it into the long term
stable branches or are you okay with it appearing starting with 5.20?
> +#define SFF_8636_ID 0x0
> +#define SFF_8636_ID_LEN 0x1
> +#define SFF_8024_ID_SFP 0x3
Please use the defines from include/linux/sfp.h
SFF8024_ID_SFP and SFP_PHYS_ID
prev parent reply other threads:[~2022-06-22 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 22:32 [PATCH] cxgb4: DOM support when using a QSFP to SFP adaptor Arthur Gautier
2022-06-22 5:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621222317.1cbcaaeb@kernel.org \
--to=kuba@kernel.org \
--cc=baloo@superbaloo.net \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).