netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] amt: remove unnecessary (void*) conversions.
@ 2022-06-21  2:16 Yu Zhe
  2022-06-22  5:26 ` Jakub Kicinski
  2022-06-23  0:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: Yu Zhe @ 2022-06-21  2:16 UTC (permalink / raw)
  To: ap420073, davem, edumazet, kuba, pabeni
  Cc: netdev, linux-kernel, liqiong, Yu Zhe

remove unnecessary void* type castings.

Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
---
 drivers/net/amt.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/amt.c b/drivers/net/amt.c
index be2719a3ba70..732f4c0daa73 100644
--- a/drivers/net/amt.c
+++ b/drivers/net/amt.c
@@ -1373,11 +1373,11 @@ static void amt_add_srcs(struct amt_dev *amt, struct amt_tunnel_list *tunnel,
 	int i;
 
 	if (!v6) {
-		igmp_grec = (struct igmpv3_grec *)grec;
+		igmp_grec = grec;
 		nsrcs = ntohs(igmp_grec->grec_nsrcs);
 	} else {
 #if IS_ENABLED(CONFIG_IPV6)
-		mld_grec = (struct mld2_grec *)grec;
+		mld_grec = grec;
 		nsrcs = ntohs(mld_grec->grec_nsrcs);
 #else
 	return;
@@ -1458,11 +1458,11 @@ static void amt_lookup_act_srcs(struct amt_tunnel_list *tunnel,
 	int i, j;
 
 	if (!v6) {
-		igmp_grec = (struct igmpv3_grec *)grec;
+		igmp_grec = grec;
 		nsrcs = ntohs(igmp_grec->grec_nsrcs);
 	} else {
 #if IS_ENABLED(CONFIG_IPV6)
-		mld_grec = (struct mld2_grec *)grec;
+		mld_grec = grec;
 		nsrcs = ntohs(mld_grec->grec_nsrcs);
 #else
 	return;
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] amt: remove unnecessary (void*) conversions.
  2022-06-21  2:16 [PATCH] amt: remove unnecessary (void*) conversions Yu Zhe
@ 2022-06-22  5:26 ` Jakub Kicinski
  2022-06-22  6:26   ` Taehee Yoo
  2022-06-23  0:40 ` patchwork-bot+netdevbpf
  1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-06-22  5:26 UTC (permalink / raw)
  To: Yu Zhe; +Cc: ap420073, davem, edumazet, pabeni, netdev, linux-kernel, liqiong

On Tue, 21 Jun 2022 10:16:48 +0800 Yu Zhe wrote:
> remove unnecessary void* type castings.
> 
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>

Taehee, ack?  Your call.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] amt: remove unnecessary (void*) conversions.
  2022-06-22  5:26 ` Jakub Kicinski
@ 2022-06-22  6:26   ` Taehee Yoo
  0 siblings, 0 replies; 4+ messages in thread
From: Taehee Yoo @ 2022-06-22  6:26 UTC (permalink / raw)
  To: Jakub Kicinski, Yu Zhe
  Cc: davem, edumazet, pabeni, netdev, linux-kernel, liqiong

Hi Yu Zhe,
Thanks a lot for your work!

On 6/22/22 14:26, Jakub Kicinski wrote:
> On Tue, 21 Jun 2022 10:16:48 +0800 Yu Zhe wrote:
>> remove unnecessary void* type castings.
>>
>> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> 
> Taehee, ack?  Your call.

Hi Jakub,

It looks good to me.
I tested this and It works well.

Thanks a lot!

Acked-by: Taehee Yoo <ap420073@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] amt: remove unnecessary (void*) conversions.
  2022-06-21  2:16 [PATCH] amt: remove unnecessary (void*) conversions Yu Zhe
  2022-06-22  5:26 ` Jakub Kicinski
@ 2022-06-23  0:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-06-23  0:40 UTC (permalink / raw)
  To: Yu Zhe
  Cc: ap420073, davem, edumazet, kuba, pabeni, netdev, linux-kernel,
	liqiong

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 21 Jun 2022 10:16:48 +0800 you wrote:
> remove unnecessary void* type castings.
> 
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
>  drivers/net/amt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Here is the summary with links:
  - amt: remove unnecessary (void*) conversions.
    https://git.kernel.org/netdev/net-next/c/d13a3205a717

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-23  0:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-21  2:16 [PATCH] amt: remove unnecessary (void*) conversions Yu Zhe
2022-06-22  5:26 ` Jakub Kicinski
2022-06-22  6:26   ` Taehee Yoo
2022-06-23  0:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).