[PATCH net-next] raw: remove unused variables from raw6_icmp_error()

[PATCH net-next] raw: remove unused variables from raw6_icmp_error()

[Eric Dumazet]

saddr and daddr are set but not used.

Fixes: ba44f8182ec2 ("raw: use more conventional iterators")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/ipv6/raw.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 46b560aacc11352ee9f2043c277709c28f85e610..722de9dd0ff78fbb2535165935c92fe7d7e6a8c2 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -332,7 +332,6 @@ static void rawv6_err(struct sock *sk, struct sk_buff *skb,
 void raw6_icmp_error(struct sk_buff *skb, int nexthdr,
 		u8 type, u8 code, int inner_offset, __be32 info)
 {
-	const struct in6_addr *saddr, *daddr;
 	struct net *net = dev_net(skb->dev);
 	struct hlist_nulls_head *hlist;
 	struct hlist_nulls_node *hnode;
@@ -345,8 +344,6 @@ void raw6_icmp_error(struct sk_buff *skb, int nexthdr,
 	sk_nulls_for_each(sk, hnode, hlist) {
 		/* Note: ipv6_hdr(skb) != skb->data */
 		const struct ipv6hdr *ip6h = (const struct ipv6hdr *)skb->data;
-		saddr = &ip6h->saddr;
-		daddr = &ip6h->daddr;
 
 		if (!raw_v6_match(net, sk, nexthdr, &ip6h->saddr, &ip6h->daddr,
 				  inet6_iif(skb), inet6_iif(skb)))
-- 
2.37.0.rc0.104.g0611611a94-goog

Re: [PATCH net-next] raw: remove unused variables from raw6_icmp_error()

[Jonathan Lemon]

On Wed, Jun 22, 2022 at 03:23:03AM +0000, Eric Dumazet wrote:
> saddr and daddr are set but not used.
> 
> Fixes: ba44f8182ec2 ("raw: use more conventional iterators")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>

Re: [PATCH net-next] raw: remove unused variables from raw6_icmp_error()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 22 Jun 2022 03:23:03 +0000 you wrote:
> saddr and daddr are set but not used.
> 
> Fixes: ba44f8182ec2 ("raw: use more conventional iterators")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>  net/ipv6/raw.c | 3 ---
>  1 file changed, 3 deletions(-)

Here is the summary with links:
  - [net-next] raw: remove unused variables from raw6_icmp_error()
    https://git.kernel.org/netdev/net-next/c/c4fceb46add6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html