From: Jakub Kicinski <kuba@kernel.org>
To: Aleksey Shumnik <ashumnik9@gmail.com>
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, xeb@mail.ru
Subject: Re: [PATCH] net/ipv4/ip_gre.c net/ipv6/ip6_gre.c: ip and gre header are recorded twice
Date: Fri, 24 Jun 2022 10:17:43 -0700 [thread overview]
Message-ID: <20220624101743.78d0ece7@kernel.org> (raw)
In-Reply-To: <CAJGXZLg9Z3O8w_bTLhyU1m7Oemfx561X0ji0MdYRZG8XKmxBpg@mail.gmail.com>
On Fri, 24 Jun 2022 16:51:41 +0300 Aleksey Shumnik wrote:
> On Fri, Jun 24, 2022 at 6:26 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > > I use SOCK_DGRAM
> >
> > Strange.
>
> Why is it strange?
I meant surprising, I'd have thought we could miss something like that
for RAW sockets maybe but DGRAM/ICMP should work.
> > > I want to find out, the creation of gre and ip header twice, is it a
> > > feature or a bug?
> >
> > I can't think why that'd be a feature. Could add this case to selftests
> > to show how to repro and catch regressions?
>
> I don't really know how to do it, but I'll try
> If we just talk about selftests/net, then everything has passed
What I'm looking for is a bash(?) script which sets up the tunnel sends
a packet and checks if the headers are valid.
> > > I did everything according to the instructions, hope everything is
> > > correct this time.
> >
> > Nope, still mangled.
>
> Strangely, everything works fine for me
Depends on definition of "works", are you saying you can download this:
https://lore.kernel.org/all/CAJGXZLiNo=G=5889sPyiCZVjRf65Ygov3=DWFgKmay+Dy3wCYw@mail.gmail.com/raw
which is your email in text form and `git am` will accept that as a
patch?
next prev parent reply other threads:[~2022-06-24 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 13:48 [PATCH] net/ipv4/ip_gre.c net/ipv6/ip6_gre.c: ip and gre header are recorded twice Aleksey Shumnik
2022-06-23 0:19 ` Jakub Kicinski
2022-06-23 13:51 ` Aleksey Shumnik
2022-06-24 3:26 ` Jakub Kicinski
2022-06-24 13:51 ` Aleksey Shumnik
2022-06-24 17:17 ` Jakub Kicinski [this message]
2022-06-28 15:18 ` Aleksey Shumnik
2022-07-02 1:31 ` Jakub Kicinski
2022-07-02 1:42 ` Jakub Kicinski
2022-07-07 16:41 ` Aleksey Shumnik
2022-07-07 23:23 ` Jakub Kicinski
2022-07-28 13:54 ` Aleksey Shumnik
2022-07-28 15:17 ` Jakub Kicinski
2022-07-29 11:56 ` Aleksey Shumnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624101743.78d0ece7@kernel.org \
--to=kuba@kernel.org \
--cc=ashumnik9@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=xeb@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).