From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613B4C43334 for ; Mon, 27 Jun 2022 15:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238512AbiF0Plt (ORCPT ); Mon, 27 Jun 2022 11:41:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238503AbiF0Plp (ORCPT ); Mon, 27 Jun 2022 11:41:45 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80C581A049; Mon, 27 Jun 2022 08:41:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id AF98BCE1B71; Mon, 27 Jun 2022 15:41:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCE4FC3411D; Mon, 27 Jun 2022 15:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656344501; bh=aiwnae3RpvaoNHCXh1x025cNVic3O5YgH/JbQXDcqyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HYMFvVWoNMbZUkhVg15LtO3y9BDYgIswDZYdFrpMdh4hKo+6ljeQ/H3/r3eQzx3q4 Pbe/huWRhSTlkvfZT06qoHfk43KazvPVU5AGlL+ejEEpf8OqQZn6issz+qaGue3NAS AYEtStU7T1xXdlK8SnGiH8uYZgQK2MOMYft37SfThhN5gM8fRIC5hVLuBdZZRmPw6b WEsA3CN+ORIwlpoCQfn38hT0bPkZGUog06+JJ5gt1SJEePy6/UyUn6LjOfdTvUPOHe XmoS81q2E1aLLaJgqvRJHNjT/jfX6a+KwqDBvQdjK6n1wBtut1M2HAOZOTlk5Jv4Qk /2fXcz/Cnyteg== Date: Mon, 27 Jun 2022 08:41:31 -0700 From: Jakub Kicinski To: Oliver Neukum Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usbnet: fix memory leak in error case Message-ID: <20220627084131.6f80c62e@kernel.org> In-Reply-To: <20220627131626.31376-1-oneukum@suse.com> References: <20220627131626.31376-1-oneukum@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 27 Jun 2022 15:16:26 +0200 Oliver Neukum wrote: > usbnet_write_cmd_async() mixed up which buffers > need to be freed in which error case. When reposting with a corrected netdev address please add a Fixes tag as well.