From: Jakub Kicinski <kuba@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, rmk+kernel@armlinux.org.uk,
boon.leong.ong@intel.com, andrew@lunn.ch, hkallweit1@gmail.com,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user
Date: Mon, 27 Jun 2022 09:12:09 -0700 [thread overview]
Message-ID: <20220627091209.4262b1d8@kernel.org> (raw)
In-Reply-To: <20220624101758.565822-1-ioana.ciornei@nxp.com>
On Fri, 24 Jun 2022 13:17:58 +0300 Ioana Ciornei wrote:
> Hide the xpcs Kconfig option from the user so that we do not end up in
> a scenario where the xpcs is enabled as a module but phylink is not
> enabled at all.
>
> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>
> All the user drivers (stmmac and sja1105) of the xpcs module already
> select both PCS_XPCS and PHYLINK, so the dependency is resolved at that
> level.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Oh, somehow I missed this patch on Friday, I applied my own
commit ebeae54d3a77 ("net: pcs: xpcs: depends on PHYLINK in Kconfig")
prev parent reply other threads:[~2022-06-27 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 10:17 [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user Ioana Ciornei
2022-06-27 16:12 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627091209.4262b1d8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).