* [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user
@ 2022-06-24 10:17 Ioana Ciornei
2022-06-27 16:12 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Ioana Ciornei @ 2022-06-24 10:17 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, netdev
Cc: rmk+kernel, boon.leong.ong, andrew, hkallweit1, Ioana Ciornei,
Randy Dunlap
Hide the xpcs Kconfig option from the user so that we do not end up in
a scenario where the xpcs is enabled as a module but phylink is not
enabled at all.
ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
All the user drivers (stmmac and sja1105) of the xpcs module already
select both PCS_XPCS and PHYLINK, so the dependency is resolved at that
level.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
drivers/net/pcs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig
index 22ba7b0b476d..9eb32220efea 100644
--- a/drivers/net/pcs/Kconfig
+++ b/drivers/net/pcs/Kconfig
@@ -6,7 +6,7 @@
menu "PCS device drivers"
config PCS_XPCS
- tristate "Synopsys DesignWare XPCS controller"
+ tristate
depends on MDIO_DEVICE && MDIO_BUS
help
This module provides helper functions for Synopsys DesignWare XPCS
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user
2022-06-24 10:17 [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user Ioana Ciornei
@ 2022-06-27 16:12 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-06-27 16:12 UTC (permalink / raw)
To: Ioana Ciornei
Cc: davem, edumazet, pabeni, netdev, rmk+kernel, boon.leong.ong,
andrew, hkallweit1, Randy Dunlap
On Fri, 24 Jun 2022 13:17:58 +0300 Ioana Ciornei wrote:
> Hide the xpcs Kconfig option from the user so that we do not end up in
> a scenario where the xpcs is enabled as a module but phylink is not
> enabled at all.
>
> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>
> All the user drivers (stmmac and sja1105) of the xpcs module already
> select both PCS_XPCS and PHYLINK, so the dependency is resolved at that
> level.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Oh, somehow I missed this patch on Friday, I applied my own
commit ebeae54d3a77 ("net: pcs: xpcs: depends on PHYLINK in Kconfig")
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-27 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-24 10:17 [PATCH net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user Ioana Ciornei
2022-06-27 16:12 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).