From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D60C43334 for ; Tue, 28 Jun 2022 05:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245161AbiF1FqP (ORCPT ); Tue, 28 Jun 2022 01:46:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245154AbiF1FqN (ORCPT ); Tue, 28 Jun 2022 01:46:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F08DE275C8 for ; Mon, 27 Jun 2022 22:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656395161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7XDCFUsIiO1RHnxPVoHQ+XTC5yX5gOLEJx5jlzpdwhw=; b=bTL1f2JK2MhZM8Tm8dVOQbmxkgwC3Pa7s8wN1jr4tXHcZevbuO4aBufO6UKfBX38xPe1UE jPdiksBjFQAEP9FOLIrv2RBn80rlF2pH8iNyA9aOxekxyqajf3sZDElMBFjb8f8etJsD2c D6JSXAtbV4Ni1LyiRP7oEm8PW4xdxrA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-42-NzUvvc3MN922moTrME3jFw-1; Tue, 28 Jun 2022 01:46:00 -0400 X-MC-Unique: NzUvvc3MN922moTrME3jFw-1 Received: by mail-wm1-f71.google.com with SMTP id 10-20020a1c020a000000b003a03f8cc1acso5072411wmc.6 for ; Mon, 27 Jun 2022 22:46:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7XDCFUsIiO1RHnxPVoHQ+XTC5yX5gOLEJx5jlzpdwhw=; b=D63O2nGryaBIqp2INAlW/UjxoFcUxELaqKYJNKUovZqZIDylnv/d7VXvzlbDSHxq3D lHMT7fOGrC6bFAQlWU/emMZ9F2lQiU2D4z3BJ56kzvT9TXE2fSmOF5D5wMp0uatOBaVp ef1T0cWZORwnGQaJ5dGx1Hq1LAkiKSHzqDXq2Q+3qfBk78ZU5ddibtNH59cvwTe0P4gn KKZDVsWJfK787QFhFGEhDnhXq7XlvQcVDqPSFAmR9xU9QEYlRgbmR/vSTOf1SWLbbyvg 4KTeoyBzxS6YR2HCkuIeCoiFAUy94InxzJnmcuq3zHVuDi6A7KGoYzEkXGGm0yMxtESw i6fQ== X-Gm-Message-State: AJIora9HfKn++I/hS1FBxHQmJHQmBj1yZJaakEBpuBgDnAB2snDt0cdZ AReJj223/RtsIqrcFBWVykvvrIewevB0yMjnt+l077R0du4RdJOhfs0Doq5JHrZFZ6iO9Wx9Fk9 kJVTsuy7E3/QvzJ59 X-Received: by 2002:a05:600c:21ca:b0:3a0:48e6:60cb with SMTP id x10-20020a05600c21ca00b003a048e660cbmr12064703wmj.195.1656395159345; Mon, 27 Jun 2022 22:45:59 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u1kNy6ksKWTPEZ6IXDwV0UKlQdlBRLnRI/epxlGzaTFb6xBerM5hZUzFha89n6poU/6PoMPw== X-Received: by 2002:a05:600c:21ca:b0:3a0:48e6:60cb with SMTP id x10-20020a05600c21ca00b003a048e660cbmr12064664wmj.195.1656395159084; Mon, 27 Jun 2022 22:45:59 -0700 (PDT) Received: from redhat.com ([2.52.23.204]) by smtp.gmail.com with ESMTPSA id 7-20020a05600c024700b003a03e63e428sm15257206wmj.36.2022.06.27.22.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 22:45:58 -0700 (PDT) Date: Tue, 28 Jun 2022 01:45:51 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: Xuan Zhuo , virtualization , Richard Weinberger , Anton Ivanov , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev , platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm , "open list:XDP (eXpress Data Path)" , kangjie.xu@linux.alibaba.com Subject: Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data Message-ID: <20220628014309-mutt-send-email-mst@kernel.org> References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> <20220624025621.128843-26-xuanzhuo@linux.alibaba.com> <20220624025817-mutt-send-email-mst@kernel.org> <20220627023841-mutt-send-email-mst@kernel.org> <20220627034733-mutt-send-email-mst@kernel.org> <20220627074723-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 28, 2022 at 11:50:37AM +0800, Jason Wang wrote: > On Mon, Jun 27, 2022 at 7:53 PM Michael S. Tsirkin wrote: > > > > On Mon, Jun 27, 2022 at 04:14:20PM +0800, Jason Wang wrote: > > > On Mon, Jun 27, 2022 at 3:58 PM Michael S. Tsirkin wrote: > > > > > > > > On Mon, Jun 27, 2022 at 03:45:30PM +0800, Jason Wang wrote: > > > > > On Mon, Jun 27, 2022 at 2:39 PM Michael S. Tsirkin wrote: > > > > > > > > > > > > On Mon, Jun 27, 2022 at 10:30:42AM +0800, Jason Wang wrote: > > > > > > > On Fri, Jun 24, 2022 at 2:59 PM Michael S. Tsirkin wrote: > > > > > > > > > > > > > > > > On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > > > > > > > > > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > > > > > > > > > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > > > > > > > > > > > > > > > > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. > > > > > > > > > > > > > > > > What exactly is meant by not breaking uABI? > > > > > > > > Users are supposed to be prepared for struct size to change ... no? > > > > > > > > > > > > > > Not sure, any doc for this? > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > Well we have this: > > > > > > > > > > > > The drivers SHOULD only map part of configuration structure > > > > > > large enough for device operation. The drivers MUST handle > > > > > > an unexpectedly large \field{length}, but MAY check that \field{length} > > > > > > is large enough for device operation. > > > > > > > > > > Yes, but that's the device/driver interface. What's done here is the > > > > > userspace/kernel. > > > > > > > > > > Userspace may break if it uses e.g sizeof(struct virtio_pci_common_cfg)? > > > > > > > > > > Thanks > > > > > > > > Hmm I guess there's risk... but then how are we going to maintain this > > > > going forward? Add a new struct on any change? > > > > > > This is the way we have used it for the past 5 or more years. I don't > > > see why this must be handled in the vq reset feature. > > > > > > >Can we at least > > > > prevent this going forward somehow? > > > > > > Like have some padding? > > > > > > Thanks > > > > Maybe - this is what QEMU does ... > > Do you want this to be addressed in this series (it's already very huge anyhow)? > > Thanks Let's come up with a solution at least. QEMU does not seem to need the struct. Let's just put it in virtio_pci_modern.h for now then? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Since I want to add queue_reset after queue_notify_data, I submitted > > > > > > > > > this patch first. > > > > > > > > > > > > > > > > > > Signed-off-by: Xuan Zhuo > > > > > > > > > Acked-by: Jason Wang > > > > > > > > > --- > > > > > > > > > include/uapi/linux/virtio_pci.h | 7 +++++++ > > > > > > > > > 1 file changed, 7 insertions(+) > > > > > > > > > > > > > > > > > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > > > > > > > > > index 3a86f36d7e3d..22bec9bd0dfc 100644 > > > > > > > > > --- a/include/uapi/linux/virtio_pci.h > > > > > > > > > +++ b/include/uapi/linux/virtio_pci.h > > > > > > > > > @@ -166,6 +166,13 @@ struct virtio_pci_common_cfg { > > > > > > > > > __le32 queue_used_hi; /* read-write */ > > > > > > > > > }; > > > > > > > > > > > > > > > > > > +struct virtio_pci_common_cfg_notify { > > > > > > > > > + struct virtio_pci_common_cfg cfg; > > > > > > > > > + > > > > > > > > > + __le16 queue_notify_data; /* read-write */ > > > > > > > > > + __le16 padding; > > > > > > > > > +}; > > > > > > > > > + > > > > > > > > > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > > > > > > > > > struct virtio_pci_cfg_cap { > > > > > > > > > struct virtio_pci_cap cap; > > > > > > > > > -- > > > > > > > > > 2.31.0 > > > > > > > > > > > > > > > > > > > >