From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48903C43334 for ; Wed, 29 Jun 2022 03:57:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229492AbiF2D5B (ORCPT ); Tue, 28 Jun 2022 23:57:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbiF2D4a (ORCPT ); Tue, 28 Jun 2022 23:56:30 -0400 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ACBA2EA0C for ; Tue, 28 Jun 2022 20:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1656474972; x=1688010972; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CpARIZ88B6LpHVrC9VDFCk/8IW9GbXo1UW3T9JUvOVk=; b=V8p4s/QSDQAUppXdkjAp9v9/sEFqmurceNuOon3S6x/74S8YYchn3DTq aJgw2XlJxygBok0MToI1mDsF+LT8Sn/JIor9DwkpaTRkLGczb+JlYfwq6 kIUkVIo4dHTxpiGLhuUzvoHdjvMRSbX8mBpwLnAR9gsBq26oxFExDeorZ U=; X-IronPort-AV: E=Sophos;i="5.92,230,1650931200"; d="scan'208";a="212897893" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1d-9a235a16.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 29 Jun 2022 03:56:01 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1d-9a235a16.us-east-1.amazon.com (Postfix) with ESMTPS id B3B7F800C0; Wed, 29 Jun 2022 03:55:58 +0000 (UTC) Received: from EX13D04ANC001.ant.amazon.com (10.43.157.89) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1497.36; Wed, 29 Jun 2022 03:55:57 +0000 Received: from 88665a182662.ant.amazon.com (10.43.161.183) by EX13D04ANC001.ant.amazon.com (10.43.157.89) with Microsoft SMTP Server (TLS) id 15.0.1497.36; Wed, 29 Jun 2022 03:55:54 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , , Subject: Re: [PATCH v3 net] af_unix: Do not call kmemdup() for init_net's sysctl table. Date: Tue, 28 Jun 2022 20:55:46 -0700 Message-ID: <20220629035546.58196-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220628205125.2b443819@kernel.org> References: <20220628205125.2b443819@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.43.161.183] X-ClientProxiedBy: EX13D02UWB004.ant.amazon.com (10.43.161.11) To EX13D04ANC001.ant.amazon.com (10.43.157.89) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Tue, 28 Jun 2022 20:51:25 -0700 > On Mon, 27 Jun 2022 16:36:27 -0700 Kuniyuki Iwashima wrote: > > While setting up init_net's sysctl table, we need not duplicate the > > global table and can use it directly as ipv4_sysctl_init_net() does. > > > > Unlike IPv4, AF_UNIX does not have a huge sysctl table for now, so it > > cannot be a problem, but this patch makes code consistent. > > Thanks for the extra info. It sounds like an optimization, tho. > We save one table's worth of memory. Any objections to applying > this to net-next? I'm fine with net-next. Thank you, Kuniyuki > > Fixes: 1597fbc0faf8 ("[UNIX]: Make the unix sysctl tables per-namespace") > > Acked-by: Eric W. Biederman > > Signed-off-by: Kuniyuki Iwashima