From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62CAECCA47F for ; Wed, 29 Jun 2022 09:28:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232904AbiF2J2E (ORCPT ); Wed, 29 Jun 2022 05:28:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232776AbiF2J2D (ORCPT ); Wed, 29 Jun 2022 05:28:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6248439158 for ; Wed, 29 Jun 2022 02:28:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ECFEA61E1E for ; Wed, 29 Jun 2022 09:27:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8B7FC34114; Wed, 29 Jun 2022 09:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656494879; bh=zIzhNyDC6fL9K9eUM/aov3cJHME6f/of4wgLpItd2wg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gL5d1pDXiFrYmG1vipwNaPNaeo24jSfkfosQHThuaPsHqY/kw7NisJebTx8Cap+aw xZLsVP8zkxiSWDbwbwR06IxiblOwZfCQ/HU19xiJWQ9O3TbNmYTpZTf5xqPofYt7y3 K52iRF/WIsV/CzDHbLpaBb6Phvwl/viS/5Jy8CQfh74LTYWrtdiAlW7C8nw0JrmZGf ROtIHjc+8DIzb9dI5+xNXZwXC30i8U3ElT6vDoNbzT35rEdB9UfXrlP6nguAApbyyA L6IRhPrxCDPBGk6CDOrKXzC5f3EY6+nFMRpA4WbnHhDJ2RkN3KnfbnfoLEEbSGWb2M L74KvBGl1belQ== Date: Wed, 29 Jun 2022 11:27:50 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Andrew Lunn Cc: "Russell King (Oracle)" , Heiner Kallweit , Alexandre Belloni , Alvin =?UTF-8?B?xaBpcHJhZ2E=?= , Claudiu Manoil , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Hauke Mehrtens , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Vladimir Oltean , Woojung Huh Subject: Re: [PATCH RFC net-next 0/4] net: dsa: always use phylink Message-ID: <20220629112750.4e0ae994@thinkpad> In-Reply-To: References: X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 29 Jun 2022 09:18:10 +0200 Andrew Lunn wrote: > > I should point out that if a DSA port can be programmed in software to > > support both SGMII and 1000baseX, this will end up selecting SGMII > > irrespective of what the hardware was wire-strapped to and how it was > > initially configured. Do we believe that would be acceptable? > > I'm pretty sure the devel b board has 1000BaseX DSA links between its > two switches. Since both should end up SGMII that should be O.K. > > Where we potentially have issues is 1000BaseX to the CPU. This is not > an issue for the Vybrid based boards, since they are fast Ethernet > only, but there are some boards with an IMX6 with 1G ethernet. I guess > they currently use 1000BaseX, and the CPU side of the link probably > has a fixed-link with phy-mode = 1000BaseX. So we might have an issue > there. If one side of the link (e.g. only the CPU eth interface) has 1000base-x specified in device-tree explicitly, the code should keep it at 1000base-x for the DSA CPU port... Marek