* [PATCH net-next] net: sparx5: mdb add/del handle non-sparx5 devices
@ 2022-06-28 7:55 Casper Andersson
2022-06-28 12:55 ` Steen Hegelund
0 siblings, 1 reply; 4+ messages in thread
From: Casper Andersson @ 2022-06-28 7:55 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Paolo Abeni
Cc: Eric Dumazet, Lars Povlsen, Steen Hegelund, UNGLinuxDriver,
netdev
When adding/deleting mdb entries on other net_devices, eg., tap
interfaces, it should not crash.
Signed-off-by: Casper Andersson <casper.casan@gmail.com>
---
drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
index 40ef9fad3a77..ec07f7d0528c 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
@@ -397,6 +397,9 @@ static int sparx5_handle_port_mdb_add(struct net_device *dev,
bool is_host;
int res, err;
+ if (!sparx5_netdevice_check(dev))
+ return -EOPNOTSUPP;
+
is_host = netif_is_bridge_master(v->obj.orig_dev);
/* When VLAN unaware the vlan value is not parsed and we receive vid 0.
@@ -480,6 +483,9 @@ static int sparx5_handle_port_mdb_del(struct net_device *dev,
u32 mact_entry, res, pgid_entry[3], misc_cfg;
bool host_ena;
+ if (!sparx5_netdevice_check(dev))
+ return -EOPNOTSUPP;
+
if (!br_vlan_enabled(spx5->hw_bridge_dev))
vid = 1;
else
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: sparx5: mdb add/del handle non-sparx5 devices
2022-06-28 7:55 [PATCH net-next] net: sparx5: mdb add/del handle non-sparx5 devices Casper Andersson
@ 2022-06-28 12:55 ` Steen Hegelund
2022-06-30 3:22 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Steen Hegelund @ 2022-06-28 12:55 UTC (permalink / raw)
To: Casper Andersson, David S. Miller, Jakub Kicinski, Paolo Abeni
Cc: Eric Dumazet, Lars Povlsen, UNGLinuxDriver, netdev
Hi Casper,
On Tue, 2022-06-28 at 09:55 +0200, Casper Andersson wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> When adding/deleting mdb entries on other net_devices, eg., tap
> interfaces, it should not crash.
>
> Signed-off-by: Casper Andersson <casper.casan@gmail.com>
> ---
> drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
> b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
> index 40ef9fad3a77..ec07f7d0528c 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
> @@ -397,6 +397,9 @@ static int sparx5_handle_port_mdb_add(struct net_device *dev,
> bool is_host;
> int res, err;
>
> + if (!sparx5_netdevice_check(dev))
> + return -EOPNOTSUPP;
> +
> is_host = netif_is_bridge_master(v->obj.orig_dev);
>
> /* When VLAN unaware the vlan value is not parsed and we receive vid 0.
> @@ -480,6 +483,9 @@ static int sparx5_handle_port_mdb_del(struct net_device *dev,
> u32 mact_entry, res, pgid_entry[3], misc_cfg;
> bool host_ena;
>
> + if (!sparx5_netdevice_check(dev))
> + return -EOPNOTSUPP;
> +
> if (!br_vlan_enabled(spx5->hw_bridge_dev))
> vid = 1;
> else
> --
> 2.30.2
>
Indeed!
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
--
Best Regards
Steen
-=-=-=-=-=-=-=-=-=-=-=-=-=-=
steen.hegelund@microchip.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: sparx5: mdb add/del handle non-sparx5 devices
2022-06-28 12:55 ` Steen Hegelund
@ 2022-06-30 3:22 ` Jakub Kicinski
2022-06-30 12:16 ` Casper Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-06-30 3:22 UTC (permalink / raw)
To: Steen Hegelund
Cc: Casper Andersson, David S. Miller, Paolo Abeni, Eric Dumazet,
Lars Povlsen, UNGLinuxDriver, netdev
On Tue, 28 Jun 2022 14:55:22 +0200 Steen Hegelund wrote:
> On Tue, 2022-06-28 at 09:55 +0200, Casper Andersson wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > When adding/deleting mdb entries on other net_devices, eg., tap
> > interfaces, it should not crash.
> >
> > Signed-off-by: Casper Andersson <casper.casan@gmail.com>
>
> Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
We need a Fixes tag here, when did it start crashing?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: sparx5: mdb add/del handle non-sparx5 devices
2022-06-30 3:22 ` Jakub Kicinski
@ 2022-06-30 12:16 ` Casper Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Casper Andersson @ 2022-06-30 12:16 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Steen Hegelund, David S. Miller, Paolo Abeni, Eric Dumazet,
Lars Povlsen, UNGLinuxDriver, netdev
Sorry, yes. This is supposed to go to net, not net-next. I will resubmit
with a fixes tag.
Best Regards,
Casper
On 2022-06-29 20:22, Jakub Kicinski wrote:
> On Tue, 28 Jun 2022 14:55:22 +0200 Steen Hegelund wrote:
> > On Tue, 2022-06-28 at 09:55 +0200, Casper Andersson wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > >
> > > When adding/deleting mdb entries on other net_devices, eg., tap
> > > interfaces, it should not crash.
> > >
> > > Signed-off-by: Casper Andersson <casper.casan@gmail.com>
> >
> > Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
>
> We need a Fixes tag here, when did it start crashing?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-30 12:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-28 7:55 [PATCH net-next] net: sparx5: mdb add/del handle non-sparx5 devices Casper Andersson
2022-06-28 12:55 ` Steen Hegelund
2022-06-30 3:22 ` Jakub Kicinski
2022-06-30 12:16 ` Casper Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).