From: Jakub Kicinski <kuba@kernel.org>
To: Jianglei Nie <niejianglei2021@163.com>
Cc: irusskikh@marvell.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: atlantic: fix potential memory leak in aq_ndev_close()
Date: Thu, 30 Jun 2022 20:19:25 -0700 [thread overview]
Message-ID: <20220630201925.4138ab9c@kernel.org> (raw)
In-Reply-To: <20220629175645.2163510-1-niejianglei2021@163.com>
On Thu, 30 Jun 2022 01:56:45 +0800 Jianglei Nie wrote:
> err = aq_nic_stop(aq_nic);
> - if (err < 0)
> - goto err_exit;
> aq_nic_deinit(aq_nic, true);
>
> err_exit:
label is now unused, please make sure you build test your changes with
W=1
next prev parent reply other threads:[~2022-07-01 3:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 17:56 [PATCH] net: atlantic: fix potential memory leak in aq_ndev_close() Jianglei Nie
2022-07-01 3:19 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-01 6:52 Jianglei Nie
2022-07-01 14:33 ` Francois Romieu
2022-09-13 6:39 Jianglei Nie
2022-09-13 10:25 ` kernel test robot
2022-09-13 14:29 ` kernel test robot
2022-09-14 1:42 Jianglei Nie
2022-09-21 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630201925.4138ab9c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niejianglei2021@163.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).