netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
	Lukasz Cieplicki <lukaszx.cieplicki@intel.com>,
	netdev@vger.kernel.org, sassmann@redhat.com,
	Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
	Gurucharan <gurucharanx.g@intel.com>
Subject: Re: [PATCH net 1/2] i40e: Fix dropped jumbo frames statistics
Date: Thu, 30 Jun 2022 21:02:02 -0700	[thread overview]
Message-ID: <20220630210202.23165f16@kernel.org> (raw)
In-Reply-To: <20220630214940.3036250-2-anthony.l.nguyen@intel.com>

On Thu, 30 Jun 2022 14:49:39 -0700 Tony Nguyen wrote:
> From: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
> 
> Dropped packets caused by too large frames were not included in
> dropped RX packets statistics.
> Issue was caused by not reading the GL_RXERR1 register. That register
> stores count of packet which was have been dropped due to too large
> size.
> 
> Fix it by reading GL_RXERR1 register for each interface.
> 
> Repro steps:
> Send a packet larger than the set MTU to SUT
> Observe rx statists: ethtool -S <interface> | grep rx | grep -v ": 0"

You should count oversized frames to rx_length_errors.

  reply	other threads:[~2022-07-01  4:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30 21:49 [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-06-30 Tony Nguyen
2022-06-30 21:49 ` [PATCH net 1/2] i40e: Fix dropped jumbo frames statistics Tony Nguyen
2022-07-01  4:02   ` Jakub Kicinski [this message]
2022-06-30 21:49 ` [PATCH net 2/2] i40e: Fix VF's MAC Address change on VM Tony Nguyen
2022-07-01 10:40 ` [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-06-30 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220630210202.23165f16@kernel.org \
    --to=kuba@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gurucharanx.g@intel.com \
    --cc=jedrzej.jagielski@intel.com \
    --cc=lukaszx.cieplicki@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).