From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, mlxsw@nvidia.com, saeedm@nvidia.com,
moshe@nvidia.com
Subject: Re: [patch net-next 2/3] net: devlink: call lockdep_assert_held() for devlink->lock directly
Date: Fri, 1 Jul 2022 09:33:16 -0700 [thread overview]
Message-ID: <20220701093316.410157f3@kernel.org> (raw)
In-Reply-To: <20220701095926.1191660-3-jiri@resnulli.us>
On Fri, 1 Jul 2022 11:59:25 +0200 Jiri Pirko wrote:
> In devlink.c there is direct access to whole struct devlink so there is
> no need to use helper. So obey the customs and work with lock directly
> avoiding helpers which might obfuscate things a bit.
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index 25b481dd1709..a7477addbd59 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -10185,7 +10185,7 @@ int devl_rate_leaf_create(struct devlink_port *devlink_port, void *priv)
> struct devlink *devlink = devlink_port->devlink;
> struct devlink_rate *devlink_rate;
>
> - devl_assert_locked(devlink_port->devlink);
> + lockdep_assert_held(&devlink_port->devlink->lock);
I don't understand why. Do we use lockdep asserts directly on rtnl_mutex
in rtnetlink.c?
next prev parent reply other threads:[~2022-07-01 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 9:59 [patch net-next 0/3] net: devlink: devl_* cosmetic fixes Jiri Pirko
2022-07-01 9:59 ` [patch net-next 1/3] net: devlink: move unlocked function prototypes alongside the locked ones Jiri Pirko
2022-07-01 9:59 ` [patch net-next 2/3] net: devlink: call lockdep_assert_held() for devlink->lock directly Jiri Pirko
2022-07-01 16:33 ` Jakub Kicinski [this message]
2022-07-02 15:58 ` Jiri Pirko
2022-07-02 19:29 ` Jakub Kicinski
2022-07-04 6:19 ` Jiri Pirko
2022-07-05 2:58 ` Jakub Kicinski
2022-07-07 8:04 ` Jiri Pirko
2022-07-01 9:59 ` [patch net-next 3/3] net: devlink: fix unlocked vs locked functions descriptions Jiri Pirko
2022-07-01 16:30 ` Jakub Kicinski
2022-07-01 16:35 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701093316.410157f3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).